From: Christoph Hellwig <hch@lst.de>
To: Hector Martin <marcan@marcan.st>, Sven Peter <sven@svenpeter.dev>,
Keith Busch <kbusch@kernel.org>, Sagi Grimberg <sagi@grimberg.me>,
James Smart <james.smart@broadcom.com>,
Chaitanya Kulkarni <kch@nvidia.com>
Cc: Alyssa Rosenzweig <alyssa@rosenzweig.io>,
asahi@lists.linux.dev, linux-nvme@lists.infradead.org
Subject: [PATCH 16/16] nvme-multipath: use atomic queue limits API for stacking limits
Date: Mon, 4 Mar 2024 07:05:00 -0700 [thread overview]
Message-ID: <20240304140500.78583-17-hch@lst.de> (raw)
In-Reply-To: <20240304140500.78583-1-hch@lst.de>
Switch to the queue_limits_* helpers to stack the bdev limits, which also
includes updating the readahead settings.
Signed-off-by: Christoph Hellwig <hch@lst.de>
---
drivers/nvme/host/core.c | 9 ++++++---
1 file changed, 6 insertions(+), 3 deletions(-)
diff --git a/drivers/nvme/host/core.c b/drivers/nvme/host/core.c
index 6413ce24fb4b1c..3f985b93a19f98 100644
--- a/drivers/nvme/host/core.c
+++ b/drivers/nvme/host/core.c
@@ -2188,6 +2188,8 @@ static int nvme_update_ns_info(struct nvme_ns *ns, struct nvme_ns_info *info)
}
if (!ret && nvme_ns_head_multipath(ns->head)) {
+ struct queue_limits lim;
+
blk_mq_freeze_queue(ns->head->disk->queue);
if (unsupported)
ns->head->disk->flags |= GENHD_FL_HIDDEN;
@@ -2196,10 +2198,11 @@ static int nvme_update_ns_info(struct nvme_ns *ns, struct nvme_ns_info *info)
set_capacity_and_notify(ns->head->disk, get_capacity(ns->disk));
set_disk_ro(ns->head->disk, nvme_ns_is_readonly(ns, info));
nvme_mpath_revalidate_paths(ns);
- blk_stack_limits(&ns->head->disk->queue->limits,
- &ns->queue->limits, 0);
- disk_update_readahead(ns->head->disk);
+ lim = queue_limits_start_update(ns->head->disk->queue);
+ queue_limits_stack_bdev(&lim, ns->disk->part0, 0,
+ ns->head->disk->disk_name);
+ ret = queue_limits_commit_update(ns->head->disk->queue, &lim);
blk_mq_unfreeze_queue(ns->head->disk->queue);
}
--
2.39.2
next prev parent reply other threads:[~2024-03-04 14:06 UTC|newest]
Thread overview: 22+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-03-04 14:04 convert nvme to atomic queue limits updates v2 Christoph Hellwig
2024-03-04 14:04 ` [PATCH 01/16] nvme: set max_hw_sectors unconditionally Christoph Hellwig
2024-03-04 15:56 ` John Garry
2024-03-04 14:04 ` [PATCH 02/16] nvme: move NVME_QUIRK_DEALLOCATE_ZEROES out of nvme_config_discard Christoph Hellwig
2024-03-04 14:04 ` [PATCH 03/16] nvme: remove nvme_revalidate_zones Christoph Hellwig
2024-03-04 14:04 ` [PATCH 04/16] nvme: move max_integrity_segments handling out of nvme_init_integrity Christoph Hellwig
2024-03-04 14:04 ` [PATCH 05/16] nvme: cleanup the nvme_init_integrity calling conventions Christoph Hellwig
2024-03-04 14:04 ` [PATCH 06/16] nvme: move blk_integrity_unregister into nvme_init_integrity Christoph Hellwig
2024-03-04 14:04 ` [PATCH 07/16] nvme: don't use nvme_update_disk_info for the multipath disk Christoph Hellwig
2024-03-04 14:04 ` [PATCH 08/16] nvme: move a few things out of nvme_update_disk_info Christoph Hellwig
2024-03-04 14:04 ` [PATCH 09/16] nvme: move setting the write cache flags out of nvme_set_queue_limits Christoph Hellwig
2024-03-04 14:04 ` [PATCH 10/16] nvme: move common logic into nvme_update_ns_info Christoph Hellwig
2024-03-04 14:04 ` [PATCH 11/16] nvme: split out a nvme_identify_ns_nvm helper Christoph Hellwig
2024-03-04 14:04 ` [PATCH 12/16] nvme: don't query identify data in configure_metadata Christoph Hellwig
2024-03-04 14:04 ` [PATCH 13/16] nvme: cleanup nvme_configure_metadata Christoph Hellwig
2024-03-04 14:04 ` [PATCH 14/16] nvme: use the atomic queue limits update API Christoph Hellwig
2024-03-26 10:24 ` Kanchan Joshi
2024-03-26 14:52 ` Christoph Hellwig
2024-03-04 14:04 ` [PATCH 15/16] nvme-multipath: pass queue_limits to blk_alloc_disk Christoph Hellwig
2024-03-04 14:05 ` Christoph Hellwig [this message]
2024-03-04 16:27 ` convert nvme to atomic queue limits updates v2 Keith Busch
2024-03-07 8:39 ` Sagi Grimberg
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20240304140500.78583-17-hch@lst.de \
--to=hch@lst.de \
--cc=alyssa@rosenzweig.io \
--cc=asahi@lists.linux.dev \
--cc=james.smart@broadcom.com \
--cc=kbusch@kernel.org \
--cc=kch@nvidia.com \
--cc=linux-nvme@lists.infradead.org \
--cc=marcan@marcan.st \
--cc=sagi@grimberg.me \
--cc=sven@svenpeter.dev \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox