Re: [PATCH v3] nvme: fix reconnection fail due to reserved tag allocation

许春光
2024-03-08T16:29:45Z

Christoph Hellwig <hch@lst.de> 于2024年3月8日周五 22:42写道：
>
> The fix looks good:
>
> Reviewed-by: Christoph Hellwig <hch@lst.de>
>
> But given that's we consolidate to a single place each for setting
> up the tagsets for admin and I/O queues, what about just killing
> the symbolic name and moving the assignments and comments directly
> into the only users?

This works now, but I donot know whether
nvme_alloc_admin_tag_set()/nvme_alloc_io_tag_set()
will be suitable for all driver in future, such as driver for apple
device not use these two funcs
to init tagset (anyway it not use these two macros too), so maybe new
driver would use these
value in other position.

>