From: Daniel Wagner <dwagner@suse.de>
To: Shin'ichiro Kawasaki <shinichiro.kawasaki@wdc.com>
Cc: linux-block@vger.kernel.org, linux-nvme@lists.infradead.org,
Chaitanya Kulkarni <chaitanyak@nvidia.com>,
Hannes Reinecke <hare@suse.de>, Daniel Wagner <dwagner@suse.de>
Subject: [PATCH blktests v1 10/18] nvme/rc: remove unused connect options
Date: Thu, 21 Mar 2024 10:47:19 +0100 [thread overview]
Message-ID: <20240321094727.6503-11-dwagner@suse.de> (raw)
In-Reply-To: <20240321094727.6503-1-dwagner@suse.de>
These options are not used, thus remove them.
Signed-off-by: Daniel Wagner <dwagner@suse.de>
---
tests/nvme/rc | 19 ++-----------------
1 file changed, 2 insertions(+), 17 deletions(-)
diff --git a/tests/nvme/rc b/tests/nvme/rc
index bcc936549689..ba83f32febb8 100644
--- a/tests/nvme/rc
+++ b/tests/nvme/rc
@@ -410,9 +410,6 @@ _nvme_connect_subsys() {
local positional_args=()
local trtype=""
local subsysnqn=""
- local traddr="$def_traddr"
- local host_traddr="$def_host_traddr"
- local trsvcid="$def_trsvcid"
local hostnqn="$def_hostnqn"
local hostid="$def_hostid"
local hostkey=""
@@ -428,18 +425,6 @@ _nvme_connect_subsys() {
while [[ $# -gt 0 ]]; do
case $1 in
- --traddr)
- traddr="$2"
- shift 2
- ;;
- --host-traddr)
- host_traddr="$2"
- shift 2
- ;;
- --trsvcid)
- trsvcid="$2"
- shift 2
- ;;
--hostnqn)
hostnqn="$2"
shift 2
@@ -498,9 +483,9 @@ _nvme_connect_subsys() {
ARGS=(--transport "${trtype}" --nqn "${subsysnqn}")
if [[ "${trtype}" == "fc" ]] ; then
- ARGS+=(--traddr "${traddr}" --host-traddr "${host_traddr}")
+ ARGS+=(--traddr "${def_traddr}" --host-traddr "${def_host_traddr}")
elif [[ "${trtype}" != "loop" ]]; then
- ARGS+=(--traddr "${traddr}" --trsvcid "${trsvcid}")
+ ARGS+=(--traddr "${def_traddr}" --trsvcid "${def_trsvcid}")
fi
ARGS+=(--hostnqn="${hostnqn}")
ARGS+=(--hostid="${hostid}")
--
2.44.0
next prev parent reply other threads:[~2024-03-21 11:02 UTC|newest]
Thread overview: 31+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-03-21 9:47 [PATCH blktests v1 00/18] refactoring and various cleanups/fixes Daniel Wagner
2024-03-21 9:47 ` [PATCH blktests v1 01/18] nvme/rc: silence error on module unload for fc Daniel Wagner
2024-03-21 9:47 ` [PATCH blktests v1 02/18] nvme/rc: silence fcloop cleanup failures Daniel Wagner
2024-03-21 9:57 ` Daniel Wagner
2024-03-22 9:14 ` Shinichiro Kawasaki
2024-03-21 9:47 ` [PATCH blktests v1 03/18] nvme/rc: log error if stale configuration is found Daniel Wagner
2024-03-21 9:47 ` [PATCH blktests v1 04/18] common/xfs: propagate errors from _xfs_run_fio_verify_io Daniel Wagner
2024-03-21 9:47 ` [PATCH blktests v1 05/18] nvme/{012,013,035}: check return value of _xfs_run_fio_verify_io Daniel Wagner
2024-03-21 9:47 ` [PATCH blktests v1 06/18] nvme/rc: use long command line option for nvme Daniel Wagner
2024-03-21 9:47 ` [PATCH blktests v1 07/18] nvme/{014,015,018,019,020,023,024,026,045,046}: " Daniel Wagner
2024-03-21 9:47 ` [PATCH blktests v1 08/18] nvme/rc: connect subsys only support long options Daniel Wagner
2024-03-21 9:47 ` [PATCH blktests v1 09/18] nvme/rc: add nqn/uuid args to target setup/cleanup helper Daniel Wagner
2024-03-22 9:17 ` Shinichiro Kawasaki
2024-03-21 9:47 ` Daniel Wagner [this message]
2024-03-21 9:47 ` [PATCH blktests v1 11/18] nvme/rc: remove correct port from target Daniel Wagner
2024-03-22 9:19 ` Shinichiro Kawasaki
2024-03-21 9:47 ` [PATCH blktests v1 12/18] nvme/031: do not open code target setup/cleanup Daniel Wagner
2024-03-21 9:47 ` [PATCH blktests v1 13/18] nvme/{rc,031}: do not cleanup external managed loop device Daniel Wagner
2024-03-22 9:21 ` Shinichiro Kawasaki
2024-03-21 9:47 ` [PATCH blktests v1 14/18] nvme: drop default trtype argument for _nvmet_connect_subsys Daniel Wagner
2024-03-22 9:23 ` Shinichiro Kawasaki
2024-03-21 9:47 ` [PATCH blktests v1 15/18] nvme: drop default subsysnqn argument from _nvme_{connect|disconnect}_subsys Daniel Wagner
2024-03-22 9:26 ` Shinichiro Kawasaki
2024-03-21 9:47 ` [PATCH blktests v1 16/18] nvme/{041,042,043,044,045,048}: do not pass default host{nqn|id} to _nvme_connect_subsys Daniel Wagner
2024-03-21 9:47 ` [PATCH blktests v1 17/18] nvme: don't assume namespace id Daniel Wagner
2024-03-21 10:19 ` Daniel Wagner
2024-03-22 9:35 ` Shinichiro Kawasaki
2024-03-22 12:34 ` Daniel Wagner
2024-03-21 9:47 ` [PATCH blktests v1 18/18] nvme/028: drop unused nvmedev Daniel Wagner
2024-03-22 9:38 ` [PATCH blktests v1 00/18] refactoring and various cleanups/fixes Shinichiro Kawasaki
2024-03-22 12:35 ` Daniel Wagner
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20240321094727.6503-11-dwagner@suse.de \
--to=dwagner@suse.de \
--cc=chaitanyak@nvidia.com \
--cc=hare@suse.de \
--cc=linux-block@vger.kernel.org \
--cc=linux-nvme@lists.infradead.org \
--cc=shinichiro.kawasaki@wdc.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox