From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 03F0BC54E64 for ; Thu, 28 Mar 2024 13:09:49 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender:List-Subscribe:List-Help :List-Post:List-Archive:List-Unsubscribe:List-Id:Content-Transfer-Encoding: MIME-Version:Message-Id:Date:Subject:Cc:To:From:Reply-To:Content-Type: Content-ID:Content-Description:Resent-Date:Resent-From:Resent-Sender: Resent-To:Resent-Cc:Resent-Message-ID:In-Reply-To:References:List-Owner; bh=ojbSBuW9t8NkBbxB8HzsJZUa41zS6xae7K3rNwVDPtU=; b=m5F/qvP6wc8mxNM8O0P/fLOzqm toXJITSiS5SnuGOMS5wVqsPsBmxS2Sf0iiVxH+fDqumguWhx6Q579x9jtob3slPJYqSYfkWomocSL ZZVkP3zcIz0Pt7eFvMvWJ7nhv4uA6I6+v3IqR59BMnpQLBFIrGE1m11mg52vaK2HWdTLp/gwZbaZU LweO89bMotFTbAXetc1yPoBxFWdvD8AcGU+vhvqsRlSKhR4wZvvK/t0VTWQNMM21B8rW3SEtYswJw d0Tmo5kVT8/ddV24VF9WduHstUB9HsfvWp63qTvQ/nOAZgJmSBQ8NvmzyhQr6OkikaAABqPjqtZsE vGLiRCiQ==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.97.1 #2 (Red Hat Linux)) id 1rppVo-0000000E3fi-46Tv; Thu, 28 Mar 2024 13:09:45 +0000 Received: from mail.tuxedocomputers.com ([157.90.84.7]) by bombadil.infradead.org with esmtps (Exim 4.97.1 #2 (Red Hat Linux)) id 1rppVk-0000000E3an-206V for linux-nvme@lists.infradead.org; Thu, 28 Mar 2024 13:09:42 +0000 Received: from wse.fritz.box (pd9e59192.dip0.t-ipconnect.de [217.229.145.146]) (Authenticated sender: wse@tuxedocomputers.com) by mail.tuxedocomputers.com (Postfix) with ESMTPA id 1F10F2FC0063; Thu, 28 Mar 2024 14:09:27 +0100 (CET) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=tuxedocomputers.com; s=default; t=1711631369; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version: content-transfer-encoding:content-transfer-encoding; bh=ojbSBuW9t8NkBbxB8HzsJZUa41zS6xae7K3rNwVDPtU=; b=NCeGZUnOUJFjf1bi7Pk2p2TSLikWJsotk0+c/Evf0+v5kTl2j/2h4zg80WC88XBDWtC3Nl p2p+RB0olc/EM5KzyOxSxsdY4LqRcUgoxYgFIWf9iN91Js9E/DEV/he0+HUuYDyzDmEf7n KwDI9URxv5om54idg6aMh8/orQIRDrU= Authentication-Results: mail.tuxedocomputers.com; auth=pass smtp.auth=wse@tuxedocomputers.com smtp.mailfrom=wse@tuxedocomputers.com From: Werner Sembach To: Keith Busch , Jens Axboe , Christoph Hellwig , Sagi Grimberg Cc: Georg Gottleuber , Werner Sembach , linux-nvme@lists.infradead.org, linux-kernel@vger.kernel.org Subject: [PATCH] nvme-pci: Add sleep quirk for Samsung 990 Evo Date: Thu, 28 Mar 2024 14:09:22 +0100 Message-Id: <20240328130923.61752-1-wse@tuxedocomputers.com> X-Mailer: git-send-email 2.34.1 MIME-Version: 1.0 Content-Transfer-Encoding: 8bit X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20240328_060941_155607_E64C79FA X-CRM114-Status: GOOD ( 11.73 ) X-BeenThere: linux-nvme@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: "Linux-nvme" Errors-To: linux-nvme-bounces+linux-nvme=archiver.kernel.org@lists.infradead.org From: Georg Gottleuber On some TUXEDO platforms, a Samsung 990 Evo NVMe leads to a high power consumption in s2idle sleep (2-3 watts). This patch applies 'Force No Simple Suspend' quirk to achieve a sleep with a lower power consumption, typically around 0.5 watts. Signed-off-by: Georg Gottleuber Signed-off-by: Werner Sembach Cc: --- drivers/nvme/host/pci.c | 11 +++++++++++ 1 file changed, 11 insertions(+) diff --git a/drivers/nvme/host/pci.c b/drivers/nvme/host/pci.c index e6267a6aa3801..63f4947c960f9 100644 --- a/drivers/nvme/host/pci.c +++ b/drivers/nvme/host/pci.c @@ -2917,6 +2917,17 @@ static unsigned long check_vendor_combination_bug(struct pci_dev *pdev) dmi_match(DMI_BOARD_NAME, "NS5x_7xPU") || dmi_match(DMI_BOARD_NAME, "PH4PRX1_PH6PRX1")) return NVME_QUIRK_FORCE_NO_SIMPLE_SUSPEND; + } else if (pdev->vendor == 0x144d && pdev->device == 0xa80d) { + /* + * Exclude Samsung 990 Evo from NVME_QUIRK_SIMPLE_SUSPEND + * because of high power consumption (> 2 Watt) in s2idle + * sleep. Only some boards with Intel CPU are affected. + */ + if (dmi_match(DMI_BOARD_NAME, "GMxPXxx") || + dmi_match(DMI_BOARD_NAME, "PH4PG31") || + dmi_match(DMI_BOARD_NAME, "PH4PRX1_PH6PRX1") || + dmi_match(DMI_BOARD_NAME, "PH6PG01_PH6PG71")) + return NVME_QUIRK_FORCE_NO_SIMPLE_SUSPEND; } return 0; -- 2.34.1