From: Christoph Hellwig <hch@lst.de>
To: Sagi Grimberg <sagi@grimberg.me>
Cc: linux-nvme@lists.infradead.org, Christoph Hellwig <hch@lst.de>,
Keith Busch <kbusch@kernel.org>,
Chaitanya Kulkarni <Chaitanya.Kulkarni@wdc.com>,
jirong.feng@easystack.cn
Subject: Re: [PATCH] nvmet: fix nvme status code when namespace is disabled
Date: Mon, 29 Apr 2024 07:14:57 +0200 [thread overview]
Message-ID: <20240429051457.GB32577@lst.de> (raw)
In-Reply-To: <20240428092540.77366-1-sagi@grimberg.me>
On Sun, Apr 28, 2024 at 12:25:40PM +0300, Sagi Grimberg wrote:
> If the user disabled a nvmet namesapce, it is removed from
s/namesapce/namespace/
(lines also look a little short here, maybe use up all 73 chars
when refreshing it).
> + if (nvmet_subsys_nsid_exists(subsys, nsid))
> + return NVME_SC_INTERNAL_PATH_ERROR;
> + else
> + return NVME_SC_INVALID_NS | NVME_SC_DNR;
No need for an else after a return.
Otherwise looks good:
Reviewed-by: Christoph Hellwig <hch@lst.de>
next prev parent reply other threads:[~2024-04-29 5:15 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-04-28 9:25 [PATCH] nvmet: fix nvme status code when namespace is disabled Sagi Grimberg
2024-04-29 5:14 ` Christoph Hellwig [this message]
2024-04-29 11:34 ` Jirong Feng
2024-04-29 11:52 ` Keith Busch
2024-04-30 3:38 ` Chaitanya Kulkarni
2024-05-23 9:49 ` Hannes Reinecke
2024-05-23 10:10 ` Sagi Grimberg
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20240429051457.GB32577@lst.de \
--to=hch@lst.de \
--cc=Chaitanya.Kulkarni@wdc.com \
--cc=jirong.feng@easystack.cn \
--cc=kbusch@kernel.org \
--cc=linux-nvme@lists.infradead.org \
--cc=sagi@grimberg.me \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox