From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 731DDC19F4F for ; Tue, 7 May 2024 23:14:28 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender:List-Subscribe:List-Help :List-Post:List-Archive:List-Unsubscribe:List-Id:Content-Transfer-Encoding: MIME-Version:References:In-Reply-To:Message-ID:Date:Subject:Cc:To:From: Reply-To:Content-Type:Content-ID:Content-Description:Resent-Date:Resent-From: Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID:List-Owner; bh=F6F6h4/rsot4QaElRvBIT/aKDOkTUuPCKCwQyZd5t4o=; b=FlT+OjrRNHfhT24Y6SAWuuQJAr YVUFRuXEh4/MXssRcThTPI5n6nmZLliqrDEOMnWasWS9aTSbnialqcN3k2hsljO+kt27TkIoBwFIl M5CRManNosuEM7YkMQcnSaSBotZ5btFJ1N35Gsbem3sGRgIX7DokKCLLrNLvJ13fTrfCDrkkvvoY5 EyDEUXP+cl+eZl3VlmWggFJyj2tQCA1G5vrtQvWh/CmcX4Im4wa0uuQcoD88zs3XtjZnhjO577VN+ G5LvYnqMgpzrhmtBdQfQYWCjIe1oWgo9FPbnR8H5UhSCKI1yG6+k8/28hOjo6Wn8DD22c79/iz/1W vMumXewg==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.97.1 #2 (Red Hat Linux)) id 1s4U0x-0000000DCzN-2YEm; Tue, 07 May 2024 23:14:27 +0000 Received: from dfw.source.kernel.org ([139.178.84.217]) by bombadil.infradead.org with esmtps (Exim 4.97.1 #2 (Red Hat Linux)) id 1s4U0Z-0000000DClk-2N07 for linux-nvme@lists.infradead.org; Tue, 07 May 2024 23:14:25 +0000 Received: from smtp.kernel.org (transwarp.subspace.kernel.org [100.75.92.58]) by dfw.source.kernel.org (Postfix) with ESMTP id E6E3A61A21; Tue, 7 May 2024 23:14:02 +0000 (UTC) Received: by smtp.kernel.org (Postfix) with ESMTPSA id B5A45C3277B; Tue, 7 May 2024 23:14:01 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1715123642; bh=Hs3S7Bam/o6E7QCw9UqHc74qAk572AAnODzDEDVeXjo=; h=From:To:Cc:Subject:Date:In-Reply-To:References:From; b=pkZWDC8z74R2b1n3eR2l8MG9dZvWmeo9XP3/ACMLmPbGGslvmPDBGt8WBQqRz7e9P vaeZmKK5SZVhpxNb9LI7jRvX/pbOzA19eOrY/f2ugIDlK5Bjhi3rYAB9b3XyEVGglu YKyuvXpJf/jrTNlt5M7UY+9NFPB/lVC7esiNnBJffEDUqIjTl4VeitR07BHogdtyNi gKWNHeW/2gCO1zVHl1t25uUltChcpNE5604GVOPrAzhsKyQ09vGmKEuu6R2L2PZtpg SwjYSnEcIr/UQ+lcrQU58nj5CiTM/8tDV823c92fda772WUFqzqP+vYCwS3lIcy9IY BRvrwzYl4RywA== From: Sasha Levin To: linux-kernel@vger.kernel.org, stable@vger.kernel.org Cc: Nilay Shroff , Christoph Hellwig , Sagi Grimberg , Chaitanya Kulkarni , Keith Busch , Sasha Levin , linux-nvme@lists.infradead.org Subject: [PATCH AUTOSEL 5.15 14/15] nvme: find numa distance only if controller has valid numa id Date: Tue, 7 May 2024 19:13:23 -0400 Message-ID: <20240507231333.394765-14-sashal@kernel.org> X-Mailer: git-send-email 2.43.0 In-Reply-To: <20240507231333.394765-1-sashal@kernel.org> References: <20240507231333.394765-1-sashal@kernel.org> MIME-Version: 1.0 X-stable: review X-Patchwork-Hint: Ignore X-stable-base: Linux 5.15.158 Content-Transfer-Encoding: 8bit X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20240507_161403_796313_14EB309E X-CRM114-Status: GOOD ( 12.33 ) X-BeenThere: linux-nvme@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: "Linux-nvme" Errors-To: linux-nvme-bounces+linux-nvme=archiver.kernel.org@lists.infradead.org From: Nilay Shroff [ Upstream commit 863fe60ed27f2c85172654a63c5b827e72c8b2e6 ] On system where native nvme multipath is configured and iopolicy is set to numa but the nvme controller numa node id is undefined or -1 (NUMA_NO_NODE) then avoid calculating node distance for finding optimal io path. In such case we may access numa distance table with invalid index and that may potentially refer to incorrect memory. So this patch ensures that if the nvme controller numa node id is -1 then instead of calculating node distance for finding optimal io path, we set the numa node distance of such controller to default 10 (LOCAL_DISTANCE). Link: https://lore.kernel.org/all/20240413090614.678353-1-nilay@linux.ibm.com/ Signed-off-by: Nilay Shroff Reviewed-by: Christoph Hellwig Reviewed-by: Sagi Grimberg Reviewed-by: Chaitanya Kulkarni Signed-off-by: Keith Busch Signed-off-by: Sasha Levin --- drivers/nvme/host/multipath.c | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-) diff --git a/drivers/nvme/host/multipath.c b/drivers/nvme/host/multipath.c index 73eddb67f0d24..f8ad43b5f0690 100644 --- a/drivers/nvme/host/multipath.c +++ b/drivers/nvme/host/multipath.c @@ -190,7 +190,8 @@ static struct nvme_ns *__nvme_find_path(struct nvme_ns_head *head, int node) if (nvme_path_is_disabled(ns)) continue; - if (READ_ONCE(head->subsys->iopolicy) == NVME_IOPOLICY_NUMA) + if (ns->ctrl->numa_node != NUMA_NO_NODE && + READ_ONCE(head->subsys->iopolicy) == NVME_IOPOLICY_NUMA) distance = node_distance(node, ns->ctrl->numa_node); else distance = LOCAL_DISTANCE; -- 2.43.0