From: Maurizio Lombardi <mlombard@redhat.com>
To: kbusch@meta.com
Cc: hare@kernel.org, sagi@grimberg.me, emilne@redhat.com,
jmeneghi@redhat.com, linux-nvme@lists.infradead.org
Subject: [PATCH 3/5] nvme-tcp: use the cancel command to perform an abort if target supports it
Date: Fri, 10 May 2024 18:30:24 +0200 [thread overview]
Message-ID: <20240510163026.786898-4-mlombard@redhat.com> (raw)
In-Reply-To: <20240510163026.786898-1-mlombard@redhat.com>
If available, use Cancel command to abort the command that timed
out instead of resetting the controller.
Signed-off-by: Maurizio Lombardi <mlombard@redhat.com>
---
drivers/nvme/host/tcp.c | 19 +++++++++++++++++++
1 file changed, 19 insertions(+)
diff --git a/drivers/nvme/host/tcp.c b/drivers/nvme/host/tcp.c
index 28bc2f373cfa..d7922fa9aabe 100644
--- a/drivers/nvme/host/tcp.c
+++ b/drivers/nvme/host/tcp.c
@@ -121,6 +121,7 @@ struct nvme_tcp_request {
size_t offset;
size_t data_sent;
enum nvme_tcp_send_state state;
+ bool aborted;
};
enum nvme_tcp_queue_flags {
@@ -2442,6 +2443,8 @@ static enum blk_eh_timer_return nvme_tcp_timeout(struct request *rq)
struct nvme_tcp_cmd_pdu *pdu = nvme_tcp_req_cmd_pdu(req);
struct nvme_command *cmd = &pdu->cmd;
int qid = nvme_tcp_queue_id(req->queue);
+ int error;
+ u32 effects;
dev_warn(ctrl->device,
"I/O tag %d (%04x) type %d opcode %#x (%s) QID %d timeout\n",
@@ -2466,10 +2469,25 @@ static enum blk_eh_timer_return nvme_tcp_timeout(struct request *rq)
return BLK_EH_DONE;
}
+ if (!req->aborted) {
+ effects = le32_to_cpu(ctrl->effects->iocs[nvme_cmd_cancel]);
+
+ if (!(effects & NVME_CMD_EFFECTS_CSUPP))
+ goto err_recovery;
+
+ error = nvme_submit_cancel_req(ctrl, rq, qid);
+ if (error)
+ goto err_recovery;
+
+ req->aborted = true;
+ return BLK_EH_RESET_TIMER;
+ }
+
/*
* LIVE state should trigger the normal error recovery which will
* handle completing this request.
*/
+err_recovery:
nvme_tcp_error_recovery(ctrl);
return BLK_EH_RESET_TIMER;
}
@@ -2514,6 +2532,7 @@ static blk_status_t nvme_tcp_setup_cmd_pdu(struct nvme_ns *ns,
req->pdu_len = 0;
req->pdu_sent = 0;
req->h2cdata_left = 0;
+ req->aborted = false;
req->data_len = blk_rq_nr_phys_segments(rq) ?
blk_rq_payload_bytes(rq) : 0;
req->curr_bio = rq->bio;
--
2.39.3
next prev parent reply other threads:[~2024-05-10 16:30 UTC|newest]
Thread overview: 15+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-05-10 16:30 [PATCH 0/5] Support for Cancel commands for host (TCP and RDMA) Maurizio Lombardi
2024-05-10 16:30 ` [PATCH 1/5] nvme: add definitions for cancel command Maurizio Lombardi
2024-05-10 16:30 ` [PATCH 2/5] nvme-core: add a function to submit a " Maurizio Lombardi
2024-05-12 14:06 ` Sagi Grimberg
2024-06-20 8:31 ` Maurizio Lombardi
2024-06-20 13:01 ` Maurizio Lombardi
2024-06-24 10:06 ` Sagi Grimberg
2024-06-26 18:38 ` [PATCH v2 7/7] nvme: add reserved ioq tags for cancel John Meneghini
2024-06-26 19:03 ` Keith Busch
2024-06-26 19:20 ` John Meneghini
2024-06-27 8:12 ` Maurizio Lombardi
2024-06-26 19:10 ` John Meneghini
2024-05-10 16:30 ` Maurizio Lombardi [this message]
2024-05-10 16:30 ` [PATCH 4/5] nvme-rdma: use the cancel command to perform an abort if target supports it Maurizio Lombardi
2024-05-10 16:30 ` [donotmerge PATCH 5/5] nvmet: target support for cancel commands Maurizio Lombardi
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20240510163026.786898-4-mlombard@redhat.com \
--to=mlombard@redhat.com \
--cc=emilne@redhat.com \
--cc=hare@kernel.org \
--cc=jmeneghi@redhat.com \
--cc=kbusch@meta.com \
--cc=linux-nvme@lists.infradead.org \
--cc=sagi@grimberg.me \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox