Linux-NVME Archive on lore.kernel.org
 help / color / mirror / Atom feed
From: Nitesh Shetty <nj.shetty@samsung.com>
To: Jens Axboe <axboe@kernel.dk>, Jonathan Corbet <corbet@lwn.net>,
	Alasdair Kergon <agk@redhat.com>,
	Mike Snitzer <snitzer@kernel.org>,
	Mikulas Patocka <mpatocka@redhat.com>,
	Keith Busch <kbusch@kernel.org>, Christoph Hellwig <hch@lst.de>,
	Sagi Grimberg <sagi@grimberg.me>,
	Chaitanya Kulkarni <kch@nvidia.com>,
	Alexander Viro <viro@zeniv.linux.org.uk>,
	Christian Brauner <brauner@kernel.org>, Jan Kara <jack@suse.cz>
Cc: martin.petersen@oracle.com, bvanassche@acm.org,
	david@fromorbit.com, hare@suse.de,
	damien.lemoal@opensource.wdc.com, anuj20.g@samsung.com,
	joshi.k@samsung.com, nitheshshetty@gmail.com,
	gost.dev@samsung.com, Nitesh Shetty <nj.shetty@samsung.com>,
	linux-block@vger.kernel.org, linux-kernel@vger.kernel.org,
	linux-doc@vger.kernel.org, dm-devel@lists.linux.dev,
	linux-nvme@lists.infradead.org, linux-fsdevel@vger.kernel.org
Subject: [PATCH v20 05/12] fs/read_write: Enable copy_file_range for block device.
Date: Mon, 20 May 2024 15:50:18 +0530	[thread overview]
Message-ID: <20240520102033.9361-6-nj.shetty@samsung.com> (raw)
In-Reply-To: <20240520102033.9361-1-nj.shetty@samsung.com>

From: Anuj Gupta <anuj20.g@samsung.com>

This is a prep patch. Allow copy_file_range to work for block devices.
Relaxing generic_copy_file_checks allows us to reuse the existing infra,
instead of adding a new user interface for block copy offload.
Change generic_copy_file_checks to use ->f_mapping->host for both inode_in
and inode_out. Allow block device in generic_file_rw_checks.

Reviewed-by: Hannes Reinecke <hare@suse.de>
Signed-off-by: Anuj Gupta <anuj20.g@samsung.com>
Signed-off-by: Nitesh Shetty <nj.shetty@samsung.com>
---
 fs/read_write.c | 8 +++++---
 1 file changed, 5 insertions(+), 3 deletions(-)

diff --git a/fs/read_write.c b/fs/read_write.c
index ef6339391351..31645ca5ed58 100644
--- a/fs/read_write.c
+++ b/fs/read_write.c
@@ -1413,8 +1413,8 @@ static int generic_copy_file_checks(struct file *file_in, loff_t pos_in,
 				    struct file *file_out, loff_t pos_out,
 				    size_t *req_count, unsigned int flags)
 {
-	struct inode *inode_in = file_inode(file_in);
-	struct inode *inode_out = file_inode(file_out);
+	struct inode *inode_in = file_in->f_mapping->host;
+	struct inode *inode_out = file_out->f_mapping->host;
 	uint64_t count = *req_count;
 	loff_t size_in;
 	int ret;
@@ -1726,7 +1726,9 @@ int generic_file_rw_checks(struct file *file_in, struct file *file_out)
 	/* Don't copy dirs, pipes, sockets... */
 	if (S_ISDIR(inode_in->i_mode) || S_ISDIR(inode_out->i_mode))
 		return -EISDIR;
-	if (!S_ISREG(inode_in->i_mode) || !S_ISREG(inode_out->i_mode))
+	if (!S_ISREG(inode_in->i_mode) && !S_ISBLK(inode_in->i_mode))
+		return -EINVAL;
+	if ((inode_in->i_mode & S_IFMT) != (inode_out->i_mode & S_IFMT))
 		return -EINVAL;
 
 	if (!(file_in->f_mode & FMODE_READ) ||
-- 
2.17.1



  parent reply	other threads:[~2024-05-20 11:45 UTC|newest]

Thread overview: 86+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
     [not found] <CGME20240520102747epcas5p33497a911ca70c991e5da8e22c5d1336b@epcas5p3.samsung.com>
2024-05-20 10:20 ` [PATCH v20 00/12] Implement copy offload support Nitesh Shetty
2024-05-20 10:20   ` [PATCH v20 01/12] block: Introduce queue limits and sysfs for copy-offload support Nitesh Shetty
2024-05-20 14:33     ` Damien Le Moal
2024-05-21  8:15       ` Nitesh Shetty
2024-05-20 22:42     ` Bart Van Assche
2024-05-21 14:25       ` Nitesh Shetty
2024-05-22 17:49         ` Bart Van Assche
2024-05-23  7:05           ` Nitesh Shetty
2024-05-21  6:57     ` Hannes Reinecke
2024-06-01  5:53     ` Christoph Hellwig
2024-06-03  6:43       ` Nitesh Shetty
2024-05-20 10:20   ` [PATCH v20 02/12] Add infrastructure for copy offload in block and request layer Nitesh Shetty
2024-05-20 15:00     ` Damien Le Moal
2024-05-21 10:50       ` Nitesh Shetty
2024-05-20 23:00     ` Bart Van Assche
2024-05-21 11:17       ` Nitesh Shetty
2024-05-22 17:58         ` Bart Van Assche
2024-05-21  7:01     ` Hannes Reinecke
2024-05-24  6:54       ` Nitesh Shetty
     [not found]       ` <66503bc7.630a0220.56c85.8b9dSMTPIN_ADDED_BROKEN@mx.google.com>
2024-05-24 13:52         ` Bart Van Assche
2024-05-27  8:27           ` Nitesh Shetty
2024-05-28 14:07       ` Bart Van Assche
2024-05-22 18:05     ` Bart Van Assche
2024-05-23 11:34       ` Nitesh Shetty
2024-05-24 20:33     ` Bart Van Assche
2024-05-29  6:17       ` Nitesh Shetty
2024-05-29  7:48         ` Damien Le Moal
2024-05-29 22:41           ` Bart Van Assche
2024-05-30  7:16             ` Nitesh Shetty
     [not found]             ` <665850bd.050a0220.a5e6b.5b72SMTPIN_ADDED_BROKEN@mx.google.com>
2024-05-30 17:11               ` Bart Van Assche
2024-05-31 10:17                 ` Nitesh Shetty
     [not found]                 ` <6659b691.630a0220.90195.d0ebSMTPIN_ADDED_BROKEN@mx.google.com>
2024-05-31 23:45                   ` Bart Van Assche
2024-06-01  5:59                 ` Christoph Hellwig
2024-06-03 17:12                   ` Bart Van Assche
2024-06-04  4:40                     ` Christoph Hellwig
2024-06-04 11:44                       ` Bart Van Assche
2024-06-05  8:20                         ` Christoph Hellwig
2024-06-24 10:44                           ` Nitesh Shetty
2024-06-06  7:28                         ` Nitesh Shetty
     [not found]                         ` <CGME20240624105121epcas5p3a5a8c73bd5ef19c02e922e5829a4dff0@epcas5p3.samsung.com>
     [not found]                           ` <6679526f.170a0220.9ffd.aefaSMTPIN_ADDED_BROKEN@mx.google.com>
2024-06-24 16:25                             ` Bart Van Assche
2024-06-24 21:55                               ` Damien Le Moal
2024-06-25 18:18                                 ` Bart Van Assche
2024-06-25 21:18                                   ` Damien Le Moal
2024-06-26  5:22                                     ` Christoph Hellwig
2024-06-28 13:53                                       ` Bart Van Assche
     [not found]                           ` <66795280.630a0220.f3ccd.b80cSMTPIN_ADDED_BROKEN@mx.google.com>
2024-06-24 22:58                             ` Keith Busch
     [not found]                       ` <CGME20240606072827epcas5p285de8d4f3b0f6d3a87f8341414336b42@epcas5p2.samsung.com>
     [not found]                         ` <66618886.630a0220.4d4fc.1c9cSMTPIN_ADDED_BROKEN@mx.google.com>
2024-06-06 16:44                           ` Bart Van Assche
2024-06-01  5:57           ` Christoph Hellwig
2024-05-20 10:20   ` [PATCH v20 03/12] block: add copy offload support Nitesh Shetty
2024-06-01  6:16     ` Christoph Hellwig
2024-06-04 10:50       ` Nitesh Shetty
2024-05-20 10:20   ` [PATCH v20 04/12] block: add emulation for copy Nitesh Shetty
2024-05-21  7:06     ` Hannes Reinecke
2024-05-21 11:29       ` Nitesh Shetty
2024-06-01  6:18     ` Christoph Hellwig
2024-05-20 10:20   ` Nitesh Shetty [this message]
2024-05-21  7:07     ` [PATCH v20 05/12] fs/read_write: Enable copy_file_range for block device Hannes Reinecke
2024-05-25 23:02     ` Dave Chinner
2024-05-28  5:57       ` Nitesh Shetty
2024-05-20 10:20   ` [PATCH v20 06/12] fs, block: copy_file_range for def_blk_ops for direct " Nitesh Shetty
2024-05-25 23:09     ` Dave Chinner
2024-05-27  8:43       ` Nitesh Shetty
2024-05-20 10:20   ` [PATCH v20 07/12] nvme: add copy offload support Nitesh Shetty
2024-06-01  6:22     ` Christoph Hellwig
2024-06-03 11:43       ` Nitesh Shetty
2024-05-20 10:20   ` [PATCH v20 08/12] nvmet: add copy command support for bdev and file ns Nitesh Shetty
2024-05-20 10:20   ` [PATCH v20 09/12] dm: Add support for copy offload Nitesh Shetty
2024-05-21  7:11     ` Hannes Reinecke
2024-05-21 14:08       ` Nitesh Shetty
2024-05-22  6:22         ` Hannes Reinecke
2024-05-22  7:10           ` Nitesh Shetty
2024-05-20 10:20   ` [PATCH v20 10/12] dm: Enable copy offload for dm-linear target Nitesh Shetty
2024-05-20 23:25     ` Bart Van Assche
2024-05-21 14:48       ` Nitesh Shetty
2024-05-20 10:20   ` [PATCH v20 11/12] null: Enable trace capability for null block Nitesh Shetty
2024-05-20 23:27     ` Bart Van Assche
2024-06-01  6:23     ` Christoph Hellwig
2024-06-03 11:04       ` Nitesh Shetty
2024-05-20 10:20   ` [PATCH v20 12/12] null_blk: add support for copy offload Nitesh Shetty
2024-05-20 23:42     ` Bart Van Assche
2024-05-21 14:46       ` Nitesh Shetty
2024-05-22 17:52         ` Bart Van Assche
2024-05-23  6:55           ` Nitesh Shetty
2024-05-20 22:54   ` [PATCH v20 00/12] Implement copy offload support Bart Van Assche
2024-06-01  5:47   ` Christoph Hellwig
2024-06-03 10:53     ` Nitesh Shetty

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20240520102033.9361-6-nj.shetty@samsung.com \
    --to=nj.shetty@samsung.com \
    --cc=agk@redhat.com \
    --cc=anuj20.g@samsung.com \
    --cc=axboe@kernel.dk \
    --cc=brauner@kernel.org \
    --cc=bvanassche@acm.org \
    --cc=corbet@lwn.net \
    --cc=damien.lemoal@opensource.wdc.com \
    --cc=david@fromorbit.com \
    --cc=dm-devel@lists.linux.dev \
    --cc=gost.dev@samsung.com \
    --cc=hare@suse.de \
    --cc=hch@lst.de \
    --cc=jack@suse.cz \
    --cc=joshi.k@samsung.com \
    --cc=kbusch@kernel.org \
    --cc=kch@nvidia.com \
    --cc=linux-block@vger.kernel.org \
    --cc=linux-doc@vger.kernel.org \
    --cc=linux-fsdevel@vger.kernel.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-nvme@lists.infradead.org \
    --cc=martin.petersen@oracle.com \
    --cc=mpatocka@redhat.com \
    --cc=nitheshshetty@gmail.com \
    --cc=sagi@grimberg.me \
    --cc=snitzer@kernel.org \
    --cc=viro@zeniv.linux.org.uk \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox