Linux-NVME Archive on lore.kernel.org
 help / color / mirror / Atom feed
From: Jason Nader <dev@kayoway.com>
To: kbusch@kernel.org, axboe@kernel.dk, hch@lst.de, sagi@grimberg.me
Cc: linux-nvme@lists.infradead.org, Jason Nader <dev@kayoway.com>
Subject: [PATCH 1/1] nvme-pci: add IGNORE_DEV_SUBNQN quirk for device 1987:5012
Date: Thu, 23 May 2024 00:47:16 +0900	[thread overview]
Message-ID: <20240522154716.156018-2-dev@kayoway.com> (raw)
In-Reply-To: <20240522154716.156018-1-dev@kayoway.com>

The NVME drive 'Corsair Force MP510' which shows in `lspci -nn` as
Phison Electronics Corporation E12 NVMe Controller [1987:5012] (rev 01),
shows the following warning in dmesg:

nvme nvme0: missing or invalid SUBNQN field.

To fix this, add NVME_QUIRK_IGNORE_DEV_SUBNQN for this device.

Signed-off-by: Jason Nader <dev@kayoway.com>
---
 drivers/nvme/host/pci.c | 3 ++-
 1 file changed, 2 insertions(+), 1 deletion(-)

diff --git a/drivers/nvme/host/pci.c b/drivers/nvme/host/pci.c
index 710043086dff..fd9982a7e3c6 100644
--- a/drivers/nvme/host/pci.c
+++ b/drivers/nvme/host/pci.c
@@ -3399,7 +3399,8 @@ static const struct pci_device_id nvme_id_table[] = {
 	{ PCI_DEVICE(0x15b7, 0x5008),   /* Sandisk SN530 */
 		.driver_data = NVME_QUIRK_BROKEN_MSI },
 	{ PCI_DEVICE(0x1987, 0x5012),	/* Phison E12 */
-		.driver_data = NVME_QUIRK_BOGUS_NID, },
+		.driver_data = NVME_QUIRK_IGNORE_DEV_SUBNQN |
+				NVME_QUIRK_BOGUS_NID, },
 	{ PCI_DEVICE(0x1987, 0x5016),	/* Phison E16 */
 		.driver_data = NVME_QUIRK_IGNORE_DEV_SUBNQN |
 				NVME_QUIRK_BOGUS_NID, },
-- 
2.45.1



      reply	other threads:[~2024-05-22 15:48 UTC|newest]

Thread overview: 2+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2024-05-22 15:47 [PATCH 0/1] nvme-pci: add IGNORE_DEV_SUBNQN quirk for device 1987:5012 Jason Nader
2024-05-22 15:47 ` Jason Nader [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20240522154716.156018-2-dev@kayoway.com \
    --to=dev@kayoway.com \
    --cc=axboe@kernel.dk \
    --cc=hch@lst.de \
    --cc=kbusch@kernel.org \
    --cc=linux-nvme@lists.infradead.org \
    --cc=sagi@grimberg.me \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox