Linux-NVME Archive on lore.kernel.org
 help / color / mirror / Atom feed
From: Christoph Hellwig <hch@lst.de>
To: Keith Busch <kbusch@kernel.org>
Cc: Shinichiro Kawasaki <shinichiro.kawasaki@wdc.com>,
	Sagi Grimberg <sagi@grimberg.me>,
	"linux-nvme@lists.infradead.org" <linux-nvme@lists.infradead.org>,
	Christoph Hellwig <hch@lst.de>
Subject: Re: [PATCH] nvme-pci: silence a lockdep complaint
Date: Wed, 22 May 2024 18:28:45 +0200	[thread overview]
Message-ID: <20240522162845.GA16783@lst.de> (raw)
In-Reply-To: <Zk4ZY2n7dSztQ4Xs@kbusch-mbp.dhcp.thefacebook.com>

On Wed, May 22, 2024 at 10:12:19AM -0600, Keith Busch wrote:
> > Tested-by: Shin'ichiro Kawasaki <shinichiro.kawasaki@wdc.com>
> 
> This is not desireable, but I give up trying to appease lockdep for this
> one.

lockdep_off is a cure that's worth than the desease.  If we can't
explain the "can't happen" using lockdep classes I don't see how
we could actually be sure that it can't happen.


  reply	other threads:[~2024-05-22 16:29 UTC|newest]

Thread overview: 14+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2024-05-22  9:15 [PATCH] nvme-pci: silence a lockdep complaint Sagi Grimberg
2024-05-22 12:18 ` Shinichiro Kawasaki
2024-05-22 16:12   ` Keith Busch
2024-05-22 16:28     ` Christoph Hellwig [this message]
2024-05-22 18:00       ` Sagi Grimberg
2024-05-22 21:36         ` Keith Busch
2024-05-23  6:54           ` Christoph Hellwig
2024-05-23 10:04             ` Sagi Grimberg
2024-05-23 12:39               ` Christoph Hellwig
2024-05-23 13:02                 ` Sagi Grimberg
2024-05-23 13:19                   ` Christoph Hellwig
2024-05-23 13:45                     ` Sagi Grimberg
2024-05-23 15:02                       ` Keith Busch
2024-05-23  8:06           ` Christoph Hellwig

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20240522162845.GA16783@lst.de \
    --to=hch@lst.de \
    --cc=kbusch@kernel.org \
    --cc=linux-nvme@lists.infradead.org \
    --cc=sagi@grimberg.me \
    --cc=shinichiro.kawasaki@wdc.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox