From: Christoph Hellwig <hch@lst.de>
To: Hannes Reinecke <hare@kernel.org>
Cc: Christoph Hellwig <hch@lst.de>, Keith Busch <kbusch@kernel.org>,
Sagi Grimberg <sagi@grimberg.me>,
Damien LeMoal <dlemoal@kernel.org>,
linux-nvme@lists.infradead.org
Subject: Re: [PATCHv2] nvme: fixup zns namespace initialisation
Date: Fri, 24 May 2024 09:36:40 +0200 [thread overview]
Message-ID: <20240524073640.GA16336@lst.de> (raw)
In-Reply-To: <20240524061808.129399-1-hare@kernel.org>
On Fri, May 24, 2024 at 08:18:08AM +0200, Hannes Reinecke wrote:
> nvme_set_chunk_sectors() needs to know whether it's a zoned namespace
> or not, but the information is only set in a later call.
It doesn't really "need to know it". It's kinda handy to warn if
a zone namespace sets an IOB.
> So move the calls around and ensure that the namespace is marked as
> non-zoned initially to avoid calculation errors when trying to derive
> a non-existing zone geometry.
>
> Fixes: c85c9ab926a5 ("nvme: split nvme_update_zone_info")
Even before that commit, nvme_update_zone_info is clearly called only
after nvme_set_chunk_sectors. The order goes back to
73d90386b559d6f4c3c5db5e6bb1b68aae8fd3e7 as far as I can tell.
Note that until the atomic limits series we kinda had to do it that
way as nvme_update_zone_info needs the sector size and other earlier
information.
The changes themselves looks fine, though:
Reviewed-by: Christoph Hellwig <hch@lst.de>
next prev parent reply other threads:[~2024-05-24 7:36 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
[not found] <CGME20240524080511epcas5p311957ded505b60f89d19355b15193600@epcas5p3.samsung.com>
2024-05-24 6:18 ` [PATCHv2] nvme: fixup zns namespace initialisation Hannes Reinecke
2024-05-24 7:36 ` Christoph Hellwig [this message]
2024-05-24 7:58 ` Nitesh Shetty
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20240524073640.GA16336@lst.de \
--to=hch@lst.de \
--cc=dlemoal@kernel.org \
--cc=hare@kernel.org \
--cc=kbusch@kernel.org \
--cc=linux-nvme@lists.infradead.org \
--cc=sagi@grimberg.me \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox