From: Christoph Hellwig <hch@lst.de>
To: Stuart Hayes <stuart.w.hayes@gmail.com>
Cc: linux-kernel@vger.kernel.org,
Greg Kroah-Hartman <gregkh@linuxfoundation.org>,
"Rafael J . Wysocki" <rafael@kernel.org>,
Tanjore Suresh <tansuresh@google.com>,
Martin Belanger <Martin.Belanger@dell.com>,
Oliver O'Halloran <oohall@gmail.com>,
Daniel Wagner <dwagner@suse.de>, Keith Busch <kbusch@kernel.org>,
Lukas Wunner <lukas@wunner.de>,
David Jeffery <djeffery@redhat.com>,
Jeremy Allison <jallison@ciq.com>, Jens Axboe <axboe@fb.com>,
Christoph Hellwig <hch@lst.de>, Sagi Grimberg <sagi@grimberg.me>,
linux-nvme@lists.infradead.org
Subject: Re: [PATCH v6 3/4] driver core: shut down devices asynchronously
Date: Tue, 28 May 2024 08:31:09 +0200 [thread overview]
Message-ID: <20240528063109.GA29965@lst.de> (raw)
In-Reply-To: <20240516154920.221445-4-stuart.w.hayes@gmail.com>
On Thu, May 16, 2024 at 10:49:19AM -0500, Stuart Hayes wrote:
> Add /sys/kernel/async_shutdown to allow user control of this feature:
>
> safe: shut down all devices synchronously, unless driver prefers async
> shutdown (driver opt-in) (default)
> on: shut down all devices asynchronously, unless disabled by the driver
> (driver opt-out)
> off: shut down all devices synchronously
The on option seems very odd. IMHO safe is the only really sensible
option, and maybe we have to support off as a bandaid due to userspace
behavior dependent on synchronous shutdown, but I'd rather try even
without that first.
next prev parent reply other threads:[~2024-05-28 6:31 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-05-16 15:49 [PATCH v6 0/4] shut down devices asynchronously Stuart Hayes
2024-05-16 15:49 ` [PATCH v6 1/4] driver core: don't always lock parent in shutdown Stuart Hayes
2024-05-16 15:49 ` [PATCH v6 2/4] driver core: separate function to shutdown one device Stuart Hayes
2024-05-16 15:49 ` [PATCH v6 3/4] driver core: shut down devices asynchronously Stuart Hayes
2024-05-28 6:31 ` Christoph Hellwig [this message]
2024-05-29 3:35 ` stuart hayes
2024-05-29 6:06 ` Greg Kroah-Hartman
2024-06-12 20:55 ` Keith Busch
2024-06-12 21:02 ` Jeremy Allison
2024-05-16 15:49 ` [PATCH v6 4/4] nvme-pci: Make driver prefer asynchronous shutdown Stuart Hayes
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20240528063109.GA29965@lst.de \
--to=hch@lst.de \
--cc=Martin.Belanger@dell.com \
--cc=axboe@fb.com \
--cc=djeffery@redhat.com \
--cc=dwagner@suse.de \
--cc=gregkh@linuxfoundation.org \
--cc=jallison@ciq.com \
--cc=kbusch@kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-nvme@lists.infradead.org \
--cc=lukas@wunner.de \
--cc=oohall@gmail.com \
--cc=rafael@kernel.org \
--cc=sagi@grimberg.me \
--cc=stuart.w.hayes@gmail.com \
--cc=tansuresh@google.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).