From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 1E0E1C25B75 for ; Thu, 6 Jun 2024 13:52:47 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender:List-Subscribe:List-Help :List-Post:List-Archive:List-Unsubscribe:List-Id:In-Reply-To:Content-Type: MIME-Version:References:Message-ID:Subject:Cc:To:From:Date:Reply-To: Content-Transfer-Encoding:Content-ID:Content-Description:Resent-Date: Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID:List-Owner; bh=nfPG+PtkeozsOGgn1qJIo5mPGt7EiWtP6SCe9QYHBk0=; b=LcR4TLZPwos7HgrAeeyCvONvVN Blx8pRM9KjJF1PL1ndeFZB1cuMDi08noGnafAhx4eV7zeNKBqYt9ajfAPs5SCff3XID/CyGF/12Gs rnvnuHuIIkSf8fup+HPJsuR1G63veCbZ0euPOB/qhVHLTjroWNwNyClZY52xlEpeeTiJSmvDVdSEj 6HNk0sWutOObQ38AJ1vpDak2J6ERQ3QAdQW3poTsa7rAmd34hEDXuQnMDsleRO7wvZmQc5aKeX4hD aUlexi1vSSLrazvTNRzEGQJpwMwMb3AUJbX102ami8xeHdts0sFOZc138mXtESYw8oH8AiclxHO80 uaMsXB1w==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.97.1 #2 (Red Hat Linux)) id 1sFDXp-00000009yDY-3eU6; Thu, 06 Jun 2024 13:52:45 +0000 Received: from verein.lst.de ([213.95.11.211]) by bombadil.infradead.org with esmtps (Exim 4.97.1 #2 (Red Hat Linux)) id 1sFDXk-00000009yCD-0AOw for linux-nvme@lists.infradead.org; Thu, 06 Jun 2024 13:52:41 +0000 Received: by verein.lst.de (Postfix, from userid 2407) id B4E9268D07; Thu, 6 Jun 2024 15:52:33 +0200 (CEST) Date: Thu, 6 Jun 2024 15:52:33 +0200 From: Christoph Hellwig To: Ofir Gal Cc: Christoph Hellwig , Sagi Grimberg , davem@davemloft.net, linux-block@vger.kernel.org, linux-nvme@lists.infradead.org, netdev@vger.kernel.org, ceph-devel@vger.kernel.org, dhowells@redhat.com, edumazet@google.com, pabeni@redhat.com, kbusch@kernel.org, axboe@kernel.dk, philipp.reisner@linbit.com, lars.ellenberg@linbit.com, christoph.boehmwalder@linbit.com, idryomov@gmail.com, xiubli@redhat.com Subject: Re: [PATCH v2 1/4] net: introduce helper sendpages_ok() Message-ID: <20240606135233.GA8879@lst.de> References: <20240530142417.146696-2-ofir.gal@volumez.com> <8d0c198f-9c15-4a8f-957a-2e4aecddd2e5@grimberg.me> <23821101-adf0-4e38-a894-fb05a19cb9c3@volumez.com> <86e60615-9286-4c9c-bffc-72304bd3cc1f@grimberg.me> <20240604042738.GA28853@lst.de> <62c2b8cd-ce6a-4e13-a58c-a6b30a0dcf17@grimberg.me> <20240606130832.GA5925@lst.de> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: User-Agent: Mutt/1.5.17 (2007-11-01) X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20240606_065240_413717_88CDD052 X-CRM114-Status: GOOD ( 10.70 ) X-BeenThere: linux-nvme@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: "Linux-nvme" Errors-To: linux-nvme-bounces+linux-nvme=archiver.kernel.org@lists.infradead.org On Thu, Jun 06, 2024 at 04:18:29PM +0300, Ofir Gal wrote: > I agree. Do we want to proceed with my patch or would we prefer a more > efficient solution? We'll need something for sure. I don't like the idea of hacking special cases that call into the networking code into the core block layer, so I think it'll have to be something more like your original patch.