From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id E59B0C27C65 for ; Tue, 11 Jun 2024 06:19:40 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender:List-Subscribe:List-Help :List-Post:List-Archive:List-Unsubscribe:List-Id:In-Reply-To:Content-Type: MIME-Version:References:Message-ID:Subject:Cc:To:From:Date:Reply-To: Content-Transfer-Encoding:Content-ID:Content-Description:Resent-Date: Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID:List-Owner; bh=ZFkiA7a2TeiDh3d0WMWpjTzJ9ahZn80L20bwLnNnJlg=; b=RnKTCj7cheQaE2NaRuWfM0Q7lV KDxUCaARXwAsqA5mAT1QVzjDaxKZS/tvMwm+X1dHHf9iGfCxATxtIiS+ogVww86wvGhA//y2TvERF FYuv4H3cxkFifpMNRaE3oHUNJIOBBhaIaEk4pG20jHqdTvZ/vI61hVN6AUVU+QdVVC5MxuBHx6zKL W/yIMFv/um5JN3Ihr2RHuL8JhpM0LreZMwpF0Wc2YHazoGzPx5OP1VP6//kKwgp3nxZLB4vnCbSMj 4UkdtsJOw/dMi4nod+03MVKVtPxyGmNPeGnbA6FMUWDZnxIbtuDq+l8i8kr0eAFl8entPKoGKUuBO SmP6JnIQ==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.97.1 #2 (Red Hat Linux)) id 1sGur5-00000007eRs-4BvF; Tue, 11 Jun 2024 06:19:40 +0000 Received: from verein.lst.de ([213.95.11.211]) by bombadil.infradead.org with esmtps (Exim 4.97.1 #2 (Red Hat Linux)) id 1sGuXH-00000007be2-2gNL; Tue, 11 Jun 2024 05:59:13 +0000 Received: by verein.lst.de (Postfix, from userid 2407) id B7C0F68CFE; Tue, 11 Jun 2024 07:59:06 +0200 (CEST) Date: Tue, 11 Jun 2024 07:59:06 +0200 From: Christoph Hellwig To: Damien Le Moal Cc: Christoph Hellwig , Jens Axboe , Geert Uytterhoeven , Richard Weinberger , Philipp Reisner , Lars Ellenberg , Christoph B??hmwalder , Josef Bacik , Ming Lei , "Michael S. Tsirkin" , Jason Wang , Roger Pau Monn?? , Alasdair Kergon , Mike Snitzer , Mikulas Patocka , Song Liu , Yu Kuai , Vineeth Vijayan , "Martin K. Petersen" , linux-m68k@lists.linux-m68k.org, linux-um@lists.infradead.org, drbd-dev@lists.linbit.com, nbd@other.debian.org, linuxppc-dev@lists.ozlabs.org, ceph-devel@vger.kernel.org, virtualization@lists.linux.dev, xen-devel@lists.xenproject.org, linux-bcache@vger.kernel.org, dm-devel@lists.linux.dev, linux-raid@vger.kernel.org, linux-mmc@vger.kernel.org, linux-mtd@lists.infradead.org, nvdimm@lists.linux.dev, linux-nvme@lists.infradead.org, linux-s390@vger.kernel.org, linux-scsi@vger.kernel.org, linux-block@vger.kernel.org Subject: Re: [PATCH 05/26] loop: regularize upgrading the lock size for direct I/O Message-ID: <20240611055906.GA3640@lst.de> References: <20240611051929.513387-1-hch@lst.de> <20240611051929.513387-6-hch@lst.de> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: User-Agent: Mutt/1.5.17 (2007-11-01) X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20240610_225912_066603_A8897FA1 X-CRM114-Status: GOOD ( 11.91 ) X-Mailman-Approved-At: Mon, 10 Jun 2024 23:19:24 -0700 X-BeenThere: linux-nvme@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: "Linux-nvme" Errors-To: linux-nvme-bounces+linux-nvme=archiver.kernel.org@lists.infradead.org On Tue, Jun 11, 2024 at 02:56:59PM +0900, Damien Le Moal wrote: > > + if (!bsize) > > + bsize = loop_default_blocksize(lo, inode->i_sb->s_bdev); > > If bsize is specified and there is a backing dev used with direct IO, should it > be checked that bsize is a multiple of bdev_logical_block_size(backing_bdev) ? For direct I/O that check would be useful. For buffered I/O we can do read-modify-write cycles. However this series is already huge and not primarily about improving the loop driver parameter validation, so I'll defer this for now.