From: Christoph Hellwig <hch@lst.de>
To: Nilay Shroff <nilay@linux.ibm.com>
Cc: Keith Busch <kbusch@meta.com>,
linux-nvme@lists.infradead.org, linux-kernel@vger.kernel.org,
linux-kselftest@vger.kernel.org, hch@lst.de, sagi@grimberg.me,
paulmck@kernel.org, davidgow@google.com,
akpm@linux-foundation.org, venkat88@linux.vnet.ibm.com,
Keith Busch <kbusch@kernel.org>
Subject: Re: [PATCH 1/2] list: introduce a new cutting helper
Date: Thu, 13 Jun 2024 10:10:16 +0200 [thread overview]
Message-ID: <20240613081016.GA21500@lst.de> (raw)
In-Reply-To: <f0e4c51c-8227-4f5c-876f-38fbb4a0e1bf@linux.ibm.com>
On Thu, Jun 13, 2024 at 10:26:11AM +0530, Nilay Shroff wrote:
> I am wondering whether we really need the _rcu version of list_cut here?
> I think that @head could point to an _rcu protected list and that's true
> for this patch. So there might be concurrent readers accessing @head using
> _rcu list-traversal primitives, such as list_for_each_entry_rcu().
Yes, I can't see how this works for a RCU lists without very careful
memory ordering.
Btw, another thing - the old vs new list ordering is reversed vs
list_splice*, which is a bit confusing (as are the parameter names
both for list_splice* and this new helper). Can you switch them
around to match?
next prev parent reply other threads:[~2024-06-13 8:10 UTC|newest]
Thread overview: 18+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-06-12 15:51 [PATCH 1/2] list: introduce a new cutting helper Keith Busch
2024-06-12 15:51 ` [PATCH 2/2] nvme: fix namespace removal list Keith Busch
2024-06-12 17:20 ` Chaitanya Kulkarni
2024-06-12 17:24 ` Keith Busch
2024-06-12 17:19 ` [PATCH 1/2] list: introduce a new cutting helper Chaitanya Kulkarni
2024-06-13 4:56 ` Nilay Shroff
2024-06-13 8:10 ` Christoph Hellwig [this message]
2024-06-13 13:00 ` Keith Busch
2024-06-13 12:56 ` Keith Busch
2024-06-13 13:41 ` Nilay Shroff
2024-06-13 14:36 ` Keith Busch
2024-06-13 14:43 ` Paul E. McKenney
2024-06-13 14:47 ` Keith Busch
2024-06-13 15:15 ` Paul E. McKenney
2024-06-13 15:40 ` Keith Busch
2024-06-13 16:01 ` Paul E. McKenney
2024-06-13 16:10 ` Keith Busch
2024-06-13 17:39 ` Paul E. McKenney
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20240613081016.GA21500@lst.de \
--to=hch@lst.de \
--cc=akpm@linux-foundation.org \
--cc=davidgow@google.com \
--cc=kbusch@kernel.org \
--cc=kbusch@meta.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-kselftest@vger.kernel.org \
--cc=linux-nvme@lists.infradead.org \
--cc=nilay@linux.ibm.com \
--cc=paulmck@kernel.org \
--cc=sagi@grimberg.me \
--cc=venkat88@linux.vnet.ibm.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).