From: Christoph Hellwig <hch@lst.de>
To: Keith Busch <kbusch@meta.com>
Cc: linux-nvme@lists.infradead.org, hch@lst.de, sagi@grimberg.me,
Keith Busch <kbusch@kernel.org>,
Venkat Rao Bagalkote <venkat88@linux.vnet.ibm.com>
Subject: Re: [PATCHv3] nvme: fix namespace removal list
Date: Thu, 13 Jun 2024 19:11:15 +0200 [thread overview]
Message-ID: <20240613171115.GA30686@lst.de> (raw)
In-Reply-To: <20240613164246.75205-1-kbusch@meta.com>
On Thu, Jun 13, 2024 at 09:42:46AM -0700, Keith Busch wrote:
> It would be neat to have a more elegant helper that we've been messing
> with, and be able to use a single srcu synchronize, but in the interest
> of time, this patch will fix the regression.
>
> I was hoping to not have per-ns srcu sync's, but this path pretty
> much only gets called on the last namespace anyway, so it should
> functionally work out to be a single sync without to optimizations.
Yeah, compared to the 2-3 synchronize_srcu calls in nvme_ns_remove
one more probably doesn't matter right now..
Looks good:
Reviewed-by: Christoph Hellwig <hch@lst.de>
next prev parent reply other threads:[~2024-06-13 17:11 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-06-13 16:42 [PATCHv3] nvme: fix namespace removal list Keith Busch
2024-06-13 17:11 ` Christoph Hellwig [this message]
2024-06-19 10:54 ` Sagi Grimberg
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20240613171115.GA30686@lst.de \
--to=hch@lst.de \
--cc=kbusch@kernel.org \
--cc=kbusch@meta.com \
--cc=linux-nvme@lists.infradead.org \
--cc=sagi@grimberg.me \
--cc=venkat88@linux.vnet.ibm.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).