From: Hannes Reinecke <hare@kernel.org>
To: Christoph Hellwig <hch@lst.de>
Cc: Sagi Grimberg <sagi@grimberg.me>, Keith Busch <kbusch@kernel.org>,
linux-nvme@lists.infradead.org, Hannes Reinecke <hare@suse.de>,
Hannes Reinecke <hare@kernel.org>
Subject: [PATCH 2/3] nvme: fixup comment for nvme RDMA Provider Type
Date: Mon, 17 Jun 2024 09:27:27 +0200 [thread overview]
Message-ID: <20240617072728.134728-3-hare@kernel.org> (raw)
In-Reply-To: <20240617072728.134728-1-hare@kernel.org>
From: Hannes Reinecke <hare@suse.de>
PRTYPE is the provider type, not the QP service type.
Fixes: eb793e2c9286 ("nvme.h: add NVMe over Fabrics definitions")
Signed-off-by: Hannes Reinecke <hare@kernel.org>
---
include/linux/nvme.h | 4 ++--
1 file changed, 2 insertions(+), 2 deletions(-)
diff --git a/include/linux/nvme.h b/include/linux/nvme.h
index 27faae34245d..0993703f6617 100644
--- a/include/linux/nvme.h
+++ b/include/linux/nvme.h
@@ -87,8 +87,8 @@ enum {
NVMF_RDMA_QPTYPE_DATAGRAM = 2, /* Reliable Datagram */
};
-/* RDMA QP Service Type codes for Discovery Log Page entry TSAS
- * RDMA_QPTYPE field
+/* RDMA Provider Type codes for Discovery Log Page entry TSAS
+ * RDMA_PRTYPE field
*/
enum {
NVMF_RDMA_PRTYPE_NOT_SPECIFIED = 1, /* No Provider Specified */
--
2.35.3
next prev parent reply other threads:[~2024-06-17 7:27 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-06-17 7:27 [PATCH 0/3] nvmet: fixup nvmetcli save/restore Hannes Reinecke
2024-06-17 7:27 ` [PATCH 1/3] nvmet: do not return 'reserved' for empty TSAS values Hannes Reinecke
2024-06-17 18:29 ` Keith Busch
2024-06-17 7:27 ` Hannes Reinecke [this message]
2024-06-18 6:45 ` [PATCH 2/3] nvme: fixup comment for nvme RDMA Provider Type Christoph Hellwig
2024-06-17 7:27 ` [PATCH 3/3] nvmet: make 'tsas' attribute idempotent for RDMA Hannes Reinecke
2024-06-18 6:46 ` Christoph Hellwig
2024-06-21 16:01 ` [PATCH 0/3] nvmet: fixup nvmetcli save/restore Keith Busch
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20240617072728.134728-3-hare@kernel.org \
--to=hare@kernel.org \
--cc=hare@suse.de \
--cc=hch@lst.de \
--cc=kbusch@kernel.org \
--cc=linux-nvme@lists.infradead.org \
--cc=sagi@grimberg.me \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).