From: Nilay Shroff <nilay@linux.ibm.com>
To: shinichiro.kawasaki@wdc.com
Cc: kbusch@kernel.org, sagi@grimberg.me, hch@lst.de,
linux-nvme@lists.infradead.org, chaitanyak@nvidia.com,
venkat88@linux.vnet.ibm.com, sachinp@linux.vnet.com,
linux-block@vger.kernel.org, gjoyce@linux.ibm.com,
Nilay Shroff <nilay@linux.ibm.com>
Subject: [PATCH blktests] loop: add test for creating/deleting file-ns
Date: Mon, 17 Jun 2024 14:47:22 +0530 [thread overview]
Message-ID: <20240617092035.2755785-1-nilay@linux.ibm.com> (raw)
This is regression test for commit be647e2c76b2
(nvme: use srcu for iterating namespace list)
This test uses a regulare file backed loop device
for creating and then deleting an NVMe namespace
in a loop.
Signed-off-by: Nilay Shroff <nilay@linux.ibm.com>
---
This regression was first reported[1], and now it's
fixed in 6.10-rc4[2]
[1] https://lore.kernel.org/all/2312e6c3-a069-4388-a863-df7e261b9d70@linux.vnet.ibm.com/
[2] commit ff0ffe5b7c3c (nvme: fix namespace removal list)
---
tests/nvme/051 | 65 ++++++++++++++++++++++++++++++++++++++++++++++
tests/nvme/051.out | 2 ++
2 files changed, 67 insertions(+)
create mode 100755 tests/nvme/051
create mode 100644 tests/nvme/051.out
diff --git a/tests/nvme/051 b/tests/nvme/051
new file mode 100755
index 0000000..0de5c56
--- /dev/null
+++ b/tests/nvme/051
@@ -0,0 +1,65 @@
+#!/bin/bash
+# SPDX-License-Identifier: GPL-3.0+
+# Copyright (C) 2024 Nilay Shroff(nilay@linux.ibm.com)
+#
+# Regression test for commit be647e2c76b2(nvme: use srcu for iterating
+# namespace list)
+
+. tests/nvme/rc
+
+DESCRIPTION="Test file-ns creation/deletion under one subsystem"
+
+requires() {
+ _nvme_requires
+ _have_loop
+ _require_nvme_trtype_is_loop
+}
+
+set_conditions() {
+ _set_nvme_trtype "$@"
+}
+
+test() {
+ echo "Running ${TEST_NAME}"
+
+ _setup_nvmet
+
+ local subsys="blktests-subsystem-1"
+ local iterations="${NVME_NUM_ITER}"
+ local loop_dev
+ local port
+
+ truncate -s "${NVME_IMG_SIZE}" "$(_nvme_def_file_path)"
+
+ loop_dev="$(losetup -f --show "$(_nvme_def_file_path)")"
+
+ port="$(_create_nvmet_port "${nvme_trtype}")"
+
+ _nvmet_target_setup --subsysnqn "${subsys}" --blkdev "${loop_dev}"
+
+ _nvme_connect_subsys --subsysnqn "${subsys}"
+
+ for ((i = 2; i <= iterations; i++)); do {
+ truncate -s "${NVME_IMG_SIZE}" "$(_nvme_def_file_path).$i"
+ _create_nvmet_ns "${subsys}" "${i}" "$(_nvme_def_file_path).$i"
+
+ # allow async request to be processed
+ sleep 1
+
+ _remove_nvmet_ns "${subsys}" "${i}"
+ rm "$(_nvme_def_file_path).$i"
+ }
+ done
+
+ _nvme_disconnect_subsys --subsysnqn "${subsys}" >> "${FULL}" 2>&1
+
+ _nvmet_target_cleanup --subsysnqn "${subsys}" --blkdev "${loop_dev}"
+
+ _remove_nvmet_port "${port}"
+
+ losetup -d "$loop_dev"
+
+ rm "$(_nvme_def_file_path)"
+
+ echo "Test complete"
+}
diff --git a/tests/nvme/051.out b/tests/nvme/051.out
new file mode 100644
index 0000000..156f068
--- /dev/null
+++ b/tests/nvme/051.out
@@ -0,0 +1,2 @@
+Running nvme/051
+Test complete
--
2.45.1
next reply other threads:[~2024-06-17 9:21 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-06-17 9:17 Nilay Shroff [this message]
2024-06-18 1:35 ` [PATCH blktests] loop: add test for creating/deleting file-ns Chaitanya Kulkarni
2024-06-18 9:28 ` Shinichiro Kawasaki
2024-06-19 6:02 ` Nilay Shroff
2024-06-19 5:53 ` Nilay Shroff
2024-06-19 7:50 ` Daniel Wagner
2024-06-19 10:07 ` Nilay Shroff
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20240617092035.2755785-1-nilay@linux.ibm.com \
--to=nilay@linux.ibm.com \
--cc=chaitanyak@nvidia.com \
--cc=gjoyce@linux.ibm.com \
--cc=hch@lst.de \
--cc=kbusch@kernel.org \
--cc=linux-block@vger.kernel.org \
--cc=linux-nvme@lists.infradead.org \
--cc=sachinp@linux.vnet.com \
--cc=sagi@grimberg.me \
--cc=shinichiro.kawasaki@wdc.com \
--cc=venkat88@linux.vnet.ibm.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).