From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 8969FC3064D for ; Wed, 26 Jun 2024 06:18:16 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender:List-Subscribe:List-Help :List-Post:List-Archive:List-Unsubscribe:List-Id:In-Reply-To:Content-Type: MIME-Version:References:Message-ID:Subject:Cc:To:From:Date:Reply-To: Content-Transfer-Encoding:Content-ID:Content-Description:Resent-Date: Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID:List-Owner; bh=WznNzAxamU/rn1oIsr/ujFQzA/utUjm7zji8ZcIyeu8=; b=H4kUUpwtjLFg/Z6Tg/JQ/DmCNn wd4WVjX3QyEM5BPNjjcwVv6NQQ0g/bv47qSwVVHj7KXD7nZV3o+4JxDNA7d8HdJGPvPQOAU2DdbKy wDNv1IqNv1eLiSIxJuY4RagyK9YjMy7eEAPKEYyPwEL1La6/39lbnbTiaMeQPriQMPz8VPy1Hc3Yn +YyOL8HBs7tubaqMlg3qRa4Q3FK8lCh3m7XoVprDYX8iPyQksJawWEYspI7cAXhNW2wrkEv/zbbIB joB2m1vs8MTibdI6kdalRZ7Ykk1OUVrTQYFBkOnQKH+yL+qcOaAvJ4hKfOgq1/CLe41ohMrnTsIS4 ROCL11rQ==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.97.1 #2 (Red Hat Linux)) id 1sMLyw-00000005Z7A-0okH; Wed, 26 Jun 2024 06:18:14 +0000 Received: from verein.lst.de ([213.95.11.211]) by bombadil.infradead.org with esmtps (Exim 4.97.1 #2 (Red Hat Linux)) id 1sMLys-00000005Z6Q-0smn; Wed, 26 Jun 2024 06:18:11 +0000 Received: by verein.lst.de (Postfix, from userid 2407) id 85E4B68BEB; Wed, 26 Jun 2024 08:18:04 +0200 (CEST) Date: Wed, 26 Jun 2024 08:18:04 +0200 From: Christoph Hellwig To: Oliver Sang Cc: Christoph Hellwig , oe-lkp@lists.linux.dev, lkp@intel.com, Jens Axboe , Damien Le Moal , Hannes Reinecke , linux-m68k@lists.linux-m68k.org, linux-um@lists.infradead.org, linux-kernel@vger.kernel.org, linux-block@vger.kernel.org, drbd-dev@lists.linbit.com, nbd@other.debian.org, linuxppc-dev@lists.ozlabs.org, ceph-devel@vger.kernel.org, virtualization@lists.linux.dev, xen-devel@lists.xenproject.org, linux-bcache@vger.kernel.org, dm-devel@lists.linux.dev, linux-raid@vger.kernel.org, linux-mmc@vger.kernel.org, linux-mtd@lists.infradead.org, nvdimm@lists.linux.dev, linux-nvme@lists.infradead.org, linux-s390@vger.kernel.org, linux-scsi@vger.kernel.org, ying.huang@intel.com, feng.tang@intel.com, fengwei.yin@intel.com Subject: Re: [axboe-block:for-next] [block] bd4a633b6f: fsmark.files_per_sec -64.5% regression Message-ID: <20240626061804.GA23481@lst.de> References: <202406241546.6bbd44a7-oliver.sang@intel.com> <20240624083537.GA19941@lst.de> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: User-Agent: Mutt/1.5.17 (2007-11-01) X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20240625_231810_426520_B9A0AA9C X-CRM114-Status: GOOD ( 18.98 ) X-BeenThere: linux-nvme@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: "Linux-nvme" Errors-To: linux-nvme-bounces+linux-nvme=archiver.kernel.org@lists.infradead.org On Wed, Jun 26, 2024 at 02:11:11PM +0800, Oliver Sang wrote: > hi, Christoph Hellwig, > > On Mon, Jun 24, 2024 at 10:35:37AM +0200, Christoph Hellwig wrote: > > This is odd to say at least. Any chance you can check the value > > of /sys/block/$DEVICE/queue/rotational for the relevant device before > > and after this commit? And is this an ATA or NVMe SSD? > > > > yeah, as Niklas mentioned, it's an ATA SSD. > > I checked the /sys/block/$DEVICE/queue/rotational before and after this commit, > both show '0'. not sure if this is expected. > > anyway, I noticed you send a patch [1] > > so I applied this patch upon bd4a633b6f, and found the performance restored. Thanks for testing!