From: Jakub Kicinski <kuba@kernel.org>
To: Aurelien Aptel <aaptel@nvidia.com>
Cc: Sagi Grimberg <sagi@grimberg.me>,
"linux-nvme@lists.infradead.org" <linux-nvme@lists.infradead.org>,
"netdev@vger.kernel.org" <netdev@vger.kernel.org>,
"hch@lst.de" <hch@lst.de>,
"kbusch@kernel.org" <kbusch@kernel.org>,
"axboe@fb.com" <axboe@fb.com>,
Chaitanya Kulkarni <chaitanyak@nvidia.com>,
"davem@davemloft.net" <davem@davemloft.net>,
Shai Malin <smalin@nvidia.com>,
"malin1024@gmail.com" <malin1024@gmail.com>,
Yoray Zack <yorayz@nvidia.com>, Jason Gunthorpe <jgg@nvidia.com>,
Tariq Toukan <tariqt@nvidia.com>,
mgurtovoy@nvidia.com, galshalom@nvidia.com, borisp@nvidia.com,
ogerlitz@nvidia.com
Subject: Re: [PATCH v25 00/20] nvme-tcp receive offloads
Date: Wed, 26 Jun 2024 08:50:17 -0700 [thread overview]
Message-ID: <20240626085017.553f793f@kernel.org> (raw)
In-Reply-To: <253v81vpw4t.fsf@nvidia.com>
On Wed, 26 Jun 2024 18:21:54 +0300 Aurelien Aptel wrote:
> We have taken some time to review your documents and code and have had
> several internal discussions regarding the CI topic. We truly appreciate
> the benefits that a CI setup could bring. However, we believe that since
> this feature primarily relies on nvme-tcp, it might achieve better
> coverage and testing if integrated with blktest. Your design focuses on
> the netdev layer, which we don't think is sufficient.
>
> blktests/nvme is designed to test the entire nvme upstream
> infrastructure including nvme-tcp that targets corner cases and bugs in
> on-going development. Chaitanya, Shinichiro, Daniel and other
> developers are actively developing blktests and running these tests in
> timely manner on latest branch in linux-nvme repo and for-next branch in
> linux-block repo.
>
> Again, we are open to provide NIC so that others can also test this
> feature on upstream kernel on our NIC to facilitate easier testing
> including distros, as long as they are testing this feature on upstream
> kernel. In this way we don't have to replicate the nvme-block storage
> stack infra/tools/tests in the framework that is focused on netdev
> development and yet achieve good coverage, what do you think?
I'm not sure we're on the same page. The ask is to run the tests on
the netdev testing branch, at 12h cadence, and generate a simple JSON
file with results we can ingest into our reporting. Extra points to
reporting it to KCIDB. You mention "framework that is focused on
netdev", IDK what you mean.
next prev parent reply other threads:[~2024-06-26 15:50 UTC|newest]
Thread overview: 37+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-05-29 16:00 [PATCH v25 00/20] nvme-tcp receive offloads Aurelien Aptel
2024-05-29 16:00 ` [PATCH v25 01/20] net: Introduce direct data placement tcp offload Aurelien Aptel
2024-05-29 16:00 ` [PATCH v25 02/20] netlink: add new family to manage ULP_DDP enablement and stats Aurelien Aptel
2024-05-29 16:00 ` [PATCH v25 03/20] iov_iter: skip copy if src == dst for direct data placement Aurelien Aptel
2024-05-29 16:00 ` [PATCH v25 04/20] net/tls,core: export get_netdev_for_sock Aurelien Aptel
2024-05-29 16:00 ` [PATCH v25 05/20] nvme-tcp: Add DDP offload control path Aurelien Aptel
2024-05-29 16:00 ` [PATCH v25 06/20] nvme-tcp: Add DDP data-path Aurelien Aptel
2024-05-29 16:00 ` [PATCH v25 07/20] nvme-tcp: RX DDGST offload Aurelien Aptel
2024-05-29 16:00 ` [PATCH v25 08/20] nvme-tcp: Deal with netdevice DOWN events Aurelien Aptel
2024-05-29 16:00 ` [PATCH v25 09/20] Documentation: add ULP DDP offload documentation Aurelien Aptel
2024-05-29 16:00 ` [PATCH v25 10/20] net/mlx5e: Rename from tls to transport static params Aurelien Aptel
2024-05-29 16:00 ` [PATCH v25 11/20] net/mlx5e: Refactor ico sq polling to get budget Aurelien Aptel
2024-05-29 16:00 ` [PATCH v25 12/20] net/mlx5: Add NVMEoTCP caps, HW bits, 128B CQE and enumerations Aurelien Aptel
2024-05-29 16:00 ` [PATCH v25 13/20] net/mlx5e: NVMEoTCP, offload initialization Aurelien Aptel
2024-05-29 16:00 ` [PATCH v25 14/20] net/mlx5e: TCP flow steering for nvme-tcp acceleration Aurelien Aptel
2024-05-29 16:00 ` [PATCH v25 15/20] net/mlx5e: NVMEoTCP, use KLM UMRs for buffer registration Aurelien Aptel
2024-05-29 16:00 ` [PATCH v25 16/20] net/mlx5e: NVMEoTCP, queue init/teardown Aurelien Aptel
2024-05-29 16:00 ` [PATCH v25 17/20] net/mlx5e: NVMEoTCP, ddp setup and resync Aurelien Aptel
2024-05-29 16:00 ` [PATCH v25 18/20] net/mlx5e: NVMEoTCP, async ddp invalidation Aurelien Aptel
2024-05-29 16:00 ` [PATCH v25 19/20] net/mlx5e: NVMEoTCP, data-path for DDP+DDGST offload Aurelien Aptel
2024-05-29 16:00 ` [PATCH v25 20/20] net/mlx5e: NVMEoTCP, statistics Aurelien Aptel
2024-05-31 1:39 ` [PATCH v25 00/20] nvme-tcp receive offloads Jakub Kicinski
2024-05-31 6:11 ` Christoph Hellwig
2024-06-03 7:09 ` Sagi Grimberg
2024-06-10 12:29 ` Christoph Hellwig
2024-06-10 14:30 ` Sagi Grimberg
2024-06-11 6:41 ` Christoph Hellwig
2024-06-11 11:01 ` Sagi Grimberg
2024-06-15 21:34 ` David Laight
2024-06-10 10:07 ` Sagi Grimberg
2024-06-10 13:23 ` Aurelien Aptel
2024-06-26 15:21 ` Aurelien Aptel
2024-06-26 15:50 ` Jakub Kicinski [this message]
2024-06-26 19:34 ` Chaitanya Kulkarni
2024-06-26 19:43 ` Jakub Kicinski
2024-06-26 20:10 ` Chaitanya Kulkarni
2024-06-26 20:14 ` Jakub Kicinski
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20240626085017.553f793f@kernel.org \
--to=kuba@kernel.org \
--cc=aaptel@nvidia.com \
--cc=axboe@fb.com \
--cc=borisp@nvidia.com \
--cc=chaitanyak@nvidia.com \
--cc=davem@davemloft.net \
--cc=galshalom@nvidia.com \
--cc=hch@lst.de \
--cc=jgg@nvidia.com \
--cc=kbusch@kernel.org \
--cc=linux-nvme@lists.infradead.org \
--cc=malin1024@gmail.com \
--cc=mgurtovoy@nvidia.com \
--cc=netdev@vger.kernel.org \
--cc=ogerlitz@nvidia.com \
--cc=sagi@grimberg.me \
--cc=smalin@nvidia.com \
--cc=tariqt@nvidia.com \
--cc=yorayz@nvidia.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).