Re: [PATCH 6/7] nvme-tcp: SOCK_NOSPACE handling

Sagi Grimberg
2024-06-26T13:45:36Z

On 26/06/2024 15:13, Hannes Reinecke wrote:
> When there is no write space on the socket we shouldn't try to
> push more data onto it; it'll stall anyway and leads to higher CPU
> utilisation. So check for sock_wspace() before queueing new
> requests and let the sock write_space() handler restart the
> submission.

What is the gain you get from this patch?

All I see is bit atomics added to the data path.