From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 6BFA9C2BD09 for ; Thu, 27 Jun 2024 05:51:30 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender:List-Subscribe:List-Help :List-Post:List-Archive:List-Unsubscribe:List-Id:In-Reply-To:Content-Type: MIME-Version:References:Message-ID:Subject:Cc:To:From:Date:Reply-To: Content-Transfer-Encoding:Content-ID:Content-Description:Resent-Date: Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID:List-Owner; bh=glZu1tzSd6/wg9bREBTg6+jiy1Z6mR1NRgEo1vzuy1I=; b=p+AHoO5rocCznaxTEP4GL5LWXt DlGzctmSs+FDOvagQtDKUKsbhYva3Hb0RXr0HIRQsJm1eRrNCAsrb87ZZCElYpDc8Pjiy+Q+Qt3Eu SbrJs/AI4cADx5W1bTZiL7jQmXT9jk/gOV0oauIlaJKnikg0UbsU8Cs/FzTPwADbDof+kvKgB0xUA EsJl0lSUGvvJnb1U6nk844pOFoRRSKLtsSl0x5KHw714EBekvi7Suznlsc1DaBx+0ZObe1enbqsRg BnNJg4VlkEkRDbi/UsiQUApm59Fw/AuEd7sHjX8pxNhwO7bgO4z0RYFkyJduyXSOmyYM1UC29ci6L zcuXQG+g==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.97.1 #2 (Red Hat Linux)) id 1sMi2a-00000009JZp-2mWI; Thu, 27 Jun 2024 05:51:28 +0000 Received: from verein.lst.de ([213.95.11.211]) by bombadil.infradead.org with esmtps (Exim 4.97.1 #2 (Red Hat Linux)) id 1sMi2X-00000009JZF-2PzG for linux-nvme@lists.infradead.org; Thu, 27 Jun 2024 05:51:27 +0000 Received: by verein.lst.de (Postfix, from userid 2407) id AA3E568AFE; Thu, 27 Jun 2024 07:51:21 +0200 (CEST) Date: Thu, 27 Jun 2024 07:51:21 +0200 From: Christoph Hellwig To: Stuart Hayes Cc: linux-kernel@vger.kernel.org, Greg Kroah-Hartman , "Rafael J . Wysocki" , Martin Belanger , Oliver O'Halloran , Daniel Wagner , Keith Busch , Lukas Wunner , David Jeffery , Jeremy Allison , Jens Axboe , Christoph Hellwig , Sagi Grimberg , linux-nvme@lists.infradead.org Subject: Re: [PATCH v7 1/4] driver core: don't always lock parent in shutdown Message-ID: <20240627055121.GA15415@lst.de> References: <20240626194650.3837-1-stuart.w.hayes@gmail.com> <20240626194650.3837-2-stuart.w.hayes@gmail.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20240626194650.3837-2-stuart.w.hayes@gmail.com> User-Agent: Mutt/1.5.17 (2007-11-01) X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20240626_225125_855799_63FFC0EC X-CRM114-Status: GOOD ( 13.70 ) X-BeenThere: linux-nvme@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: "Linux-nvme" Errors-To: linux-nvme-bounces+linux-nvme=archiver.kernel.org@lists.infradead.org On Wed, Jun 26, 2024 at 02:46:47PM -0500, Stuart Hayes wrote: > Don't lock a parent device unless it is needed in device_shutdown. This > is in preparation for making device shutdown asynchronous, when it will > be needed to allow children of a common parent to shut down > simultaneously. Looks good: Reviewed-by: Christoph Hellwig .. but I guess this means async shutdown won't work well for busses that set this flag (just usb currently)?