From: Hannes Reinecke <hare@kernel.org>
To: Christoph Hellwig <hch@lst.de>
Cc: Sagi Grimberg <sagi@grimberg.me>, Keith Busch <kbusch@kernel.org>,
linux-nvme@lists.infradead.org, Hannes Reinecke <hare@kernel.org>
Subject: [PATCH 7/8] nvme-fabrics: reset admin connection for secure concatenation
Date: Thu, 18 Jul 2024 17:06:57 +0200 [thread overview]
Message-ID: <20240718150658.99580-8-hare@kernel.org> (raw)
In-Reply-To: <20240718150658.99580-1-hare@kernel.org>
When secure concatenation is requested the connection needs to be
reset to enable TLS encryption on the new cnnection.
That implies that the original connection used for the DH-CHAP
negotiation really shouldn't be used, and we should reset as soon
as the DH-CHAP negotiation has succeeded on the admin queue.
Based on an idea from Sagi.
Signed-off-by: Hannes Reinecke <hare@kernel.org>
Reviewed-by: Sagi Grimberg <sagi@grimberg.me>
---
drivers/nvme/host/tcp.c | 9 +++++++++
1 file changed, 9 insertions(+)
diff --git a/drivers/nvme/host/tcp.c b/drivers/nvme/host/tcp.c
index b748e4033df2..08ac764ebfb0 100644
--- a/drivers/nvme/host/tcp.c
+++ b/drivers/nvme/host/tcp.c
@@ -2254,6 +2254,15 @@ static int nvme_tcp_setup_ctrl(struct nvme_ctrl *ctrl, bool new)
if (ret)
return ret;
+ if (new && ctrl->opts && ctrl->opts->concat && !ctrl->tls_pskid) {
+ dev_dbg(ctrl->device, "restart admin queue for secure concatenation\n");
+ nvme_stop_keep_alive(ctrl);
+ nvme_tcp_teardown_admin_queue(ctrl, false);
+ ret = nvme_tcp_configure_admin_queue(ctrl, false);
+ if (ret)
+ return ret;
+ }
+
if (ctrl->icdoff) {
ret = -EOPNOTSUPP;
dev_err(ctrl->device, "icdoff is not supported!\n");
--
2.35.3
next prev parent reply other threads:[~2024-07-18 15:07 UTC|newest]
Thread overview: 14+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-07-18 15:06 [PATCHv6 0/8] nvme: implement secure concatenation Hannes Reinecke
2024-07-18 15:06 ` [PATCH 1/8] crypto,fs: Separate out hkdf_extract() and hkdf_expand() Hannes Reinecke
2024-07-18 23:14 ` Eric Biggers
2024-07-19 6:13 ` Hannes Reinecke
2024-07-18 15:06 ` [PATCH 2/8] nvme: add nvme_auth_generate_psk() Hannes Reinecke
2024-07-18 15:06 ` [PATCH 3/8] nvme: add nvme_auth_generate_digest() Hannes Reinecke
2024-07-18 15:06 ` [PATCH 4/8] nvme: add nvme_auth_derive_tls_psk() Hannes Reinecke
2024-07-18 15:06 ` [PATCH 5/8] nvme-keyring: add nvme_tls_psk_refresh() Hannes Reinecke
2024-07-18 15:06 ` [PATCH 6/8] nvme-tcp: request secure channel concatenation Hannes Reinecke
2024-07-21 11:27 ` Sagi Grimberg
2024-07-22 6:36 ` Hannes Reinecke
2024-07-22 8:43 ` Hannes Reinecke
2024-07-18 15:06 ` Hannes Reinecke [this message]
2024-07-18 15:06 ` [PATCH 8/8] nvmet-tcp: support " Hannes Reinecke
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20240718150658.99580-8-hare@kernel.org \
--to=hare@kernel.org \
--cc=hch@lst.de \
--cc=kbusch@kernel.org \
--cc=linux-nvme@lists.infradead.org \
--cc=sagi@grimberg.me \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).