Linux-NVME Archive on lore.kernel.org
 help / color / mirror / Atom feed
From: Christoph Hellwig <hch@lst.de>
To: Ping Gan <jacky_gam_2001@163.com>
Cc: hare@suse.de, sagi@grimberg.me, hch@lst.de, kch@nvidia.com,
	linux-nvme@lists.infradead.org, linux-kernel@vger.kernel.org,
	ping.gan@dell.com
Subject: Re: [PATCH v2 0/2] nvmet: support unbound_wq for RDMA and TCP
Date: Fri, 19 Jul 2024 07:31:16 +0200	[thread overview]
Message-ID: <20240719053116.GA21474@lst.de> (raw)
In-Reply-To: <20240717091451.111158-1-jacky_gam_2001@163.com>

On Wed, Jul 17, 2024 at 05:14:49PM +0800, Ping Gan wrote:
> When running nvmf on SMP platform, current nvme target's RDMA and
> TCP use bounded workqueue to handle IO, but when there is other high
> workload on the system(eg: kubernetes), the competition between the 
> bounded kworker and other workload is very radical. To decrease the
> resource race of OS among them, this patchset will enable unbounded
> workqueue for nvmet-rdma and nvmet-tcp; besides that, it can also
> get some performance improvement. And this patchset bases on previous
> discussion from below session.

So why aren't we using unbound workqueues by default?  Who makea the
policy decision and how does anyone know which one to chose?



  parent reply	other threads:[~2024-07-19  5:31 UTC|newest]

Thread overview: 12+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2024-07-17  9:14 [PATCH v2 0/2] nvmet: support unbound_wq for RDMA and TCP Ping Gan
2024-07-17  9:14 ` [PATCH v2 1/2] nvmet-tcp: add unbound_wq support for nvmet-tcp Ping Gan
2024-07-17 20:28   ` Sagi Grimberg
2024-07-17  9:14 ` [PATCH v2 2/2] nvmet-rdma: add unbound_wq support for nvmet-rdma Ping Gan
2024-07-17 20:29   ` Sagi Grimberg
2024-07-19  5:31 ` Christoph Hellwig [this message]
2024-07-19  6:28   ` [PATCH v2 0/2] nvmet: support unbound_wq for RDMA and TCP Hannes Reinecke
2024-07-19  8:07     ` Ping Gan
2024-07-19  8:26       ` Hannes Reinecke
2024-07-19  8:49         ` Ping Gan
2024-07-21 11:11     ` Sagi Grimberg
2024-07-21 11:09   ` Sagi Grimberg

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20240719053116.GA21474@lst.de \
    --to=hch@lst.de \
    --cc=hare@suse.de \
    --cc=jacky_gam_2001@163.com \
    --cc=kch@nvidia.com \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-nvme@lists.infradead.org \
    --cc=ping.gan@dell.com \
    --cc=sagi@grimberg.me \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox