From: Christoph Hellwig <hch@lst.de>
To: Hannes Reinecke <hare@kernel.org>
Cc: Christoph Hellwig <hch@lst.de>, Sagi Grimberg <sagi@grimberg.me>,
Keith Busch <kbusch@kernel.org>,
linux-nvme@lists.infradead.org
Subject: Re: [PATCH 3/8] nvme-tcp: check for invalidated or revoked key
Date: Fri, 19 Jul 2024 07:37:00 +0200 [thread overview]
Message-ID: <20240719053700.GA21604@lst.de> (raw)
In-Reply-To: <20240718144858.19074-4-hare@kernel.org>
> + return (test_bit(KEY_FLAG_REVOKED, &psk->flags) ||
> + test_bit(KEY_FLAG_INVALIDATED, &psk->flags));
No need for the outer braces.
> +struct key *nvme_tls_key_lookup(key_serial_t key_id)
> +{
> + struct key *key = key_lookup(key_id);
Empty line after variable declarations, please.
> +static inline struct key *nvme_tls_key_lookup(key_serial_t key_id) { return ERR_PTR(-ENOTSUPP); }
Please avoid the overly lone line.
next prev parent reply other threads:[~2024-07-19 5:37 UTC|newest]
Thread overview: 17+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-07-18 14:48 [PATCHv6 0/8] nvme: fixes for secure concatenation Hannes Reinecke
2024-07-18 14:48 ` [PATCH 1/8] nvme-keyring: restrict match length for version '1' identifiers Hannes Reinecke
2024-07-19 5:34 ` Christoph Hellwig
2024-07-19 6:16 ` Hannes Reinecke
2024-07-18 14:48 ` [PATCH 2/8] nvme-tcp: sanitize TLS key handling Hannes Reinecke
2024-07-19 5:35 ` Christoph Hellwig
2024-07-18 14:48 ` [PATCH 3/8] nvme-tcp: check for invalidated or revoked key Hannes Reinecke
2024-07-19 5:37 ` Christoph Hellwig [this message]
2024-07-18 14:48 ` [PATCH 4/8] nvme: add a newline to the 'tls_key' sysfs attribute Hannes Reinecke
2024-07-19 5:37 ` Christoph Hellwig
2024-07-18 14:48 ` [PATCH 5/8] nvme-sysfs: add 'tls_configured_key' " Hannes Reinecke
2024-07-19 5:44 ` Christoph Hellwig
2024-07-19 6:29 ` Hannes Reinecke
2024-07-18 14:48 ` [PATCH 6/8] nvme-sysfs: add 'tls_keyring' attribute Hannes Reinecke
2024-07-18 14:48 ` [PATCH 7/8] nvmet-auth: allow to clear DH-HMAC-CHAP keys Hannes Reinecke
2024-07-18 14:48 ` [PATCH 8/8] nvme-target: do not check authentication status for admin commands twice Hannes Reinecke
2024-07-19 5:45 ` Christoph Hellwig
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20240719053700.GA21604@lst.de \
--to=hch@lst.de \
--cc=hare@kernel.org \
--cc=kbusch@kernel.org \
--cc=linux-nvme@lists.infradead.org \
--cc=sagi@grimberg.me \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox