From: Kanchan Joshi <joshi.k@samsung.com>
To: kbusch@kernel.org, hch@lst.de, sagi@grimberg.me
Cc: linux-nvme@lists.infradead.org, Kanchan Joshi <joshi.k@samsung.com>
Subject: [PATCH 3/3] nvme: reorganize nvme_ns_head fields
Date: Tue, 30 Jul 2024 16:01:38 +0530 [thread overview]
Message-ID: <20240730103138.66714-4-joshi.k@samsung.com> (raw)
In-Reply-To: <20240730103138.66714-1-joshi.k@samsung.com>
shuffle few fields to reduce the holes within nvme_ns_head.
On x86_64, the size is reduced to 1104 bytes from 1120 bytes.
Signed-off-by: Kanchan Joshi <joshi.k@samsung.com>
---
drivers/nvme/host/nvme.h | 12 ++++++------
1 file changed, 6 insertions(+), 6 deletions(-)
diff --git a/drivers/nvme/host/nvme.h b/drivers/nvme/host/nvme.h
index 7bfa410d055e..67ab626861d3 100644
--- a/drivers/nvme/host/nvme.h
+++ b/drivers/nvme/host/nvme.h
@@ -462,19 +462,19 @@ struct nvme_ns_head {
struct srcu_struct srcu;
struct nvme_subsystem *subsys;
struct nvme_ns_ids ids;
+ u8 lba_shift;
+ u16 ms;
+ u16 pi_size;
+ u8 pi_type;
+ u8 guard_type;
struct list_head entry;
struct kref ref;
bool shared;
bool passthru_err_log_enabled;
- int instance;
struct nvme_effects_log *effects;
u64 nuse;
unsigned ns_id;
- u8 lba_shift;
- u16 ms;
- u16 pi_size;
- u8 pi_type;
- u8 guard_type;
+ int instance;
#ifdef CONFIG_BLK_DEV_ZONED
u64 zsze;
#endif
--
2.25.1
next prev parent reply other threads:[~2024-07-30 10:40 UTC|newest]
Thread overview: 11+ messages / expand[flat|nested] mbox.gz Atom feed top
[not found] <CGME20240730103941epcas5p37930edd18b9649d4df2083151ed21022@epcas5p3.samsung.com>
2024-07-30 10:31 ` [PATCH 0/3] nvme_ns_head cleanup Kanchan Joshi
2024-07-30 10:31 ` [PATCH 1/3] nvme: remove a field from nvme_ns_head Kanchan Joshi
2024-07-30 15:02 ` Christoph Hellwig
2024-07-31 9:45 ` Sagi Grimberg
2024-07-31 15:36 ` Keith Busch
2024-07-30 10:31 ` [PATCH 2/3] nvme: change data type of lba_shift Kanchan Joshi
2024-07-30 15:03 ` Christoph Hellwig
2024-07-31 9:46 ` Sagi Grimberg
2024-07-30 10:31 ` Kanchan Joshi [this message]
2024-07-30 15:04 ` [PATCH 3/3] nvme: reorganize nvme_ns_head fields Christoph Hellwig
2024-07-31 9:46 ` Sagi Grimberg
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20240730103138.66714-4-joshi.k@samsung.com \
--to=joshi.k@samsung.com \
--cc=hch@lst.de \
--cc=kbusch@kernel.org \
--cc=linux-nvme@lists.infradead.org \
--cc=sagi@grimberg.me \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox