From: Christoph Hellwig <hch@lst.de>
To: Keith Busch <kbusch@kernel.org>
Cc: Puranjay Mohan <pjy@amazon.com>, Jens Axboe <axboe@kernel.dk>,
Christoph Hellwig <hch@lst.de>, Sagi Grimberg <sagi@grimberg.me>,
linux-nvme@lists.infradead.org, linux-kernel@vger.kernel.org,
puranjay@kernel.org
Subject: Re: [PATCH] nvme: check if the namespace supports metadata in nvme_map_user_request()
Date: Wed, 28 Aug 2024 06:29:15 +0200 [thread overview]
Message-ID: <20240828042915.GB30879@lst.de> (raw)
In-Reply-To: <Zs3z0CNrREMYafoC@kbusch-mbp.dhcp.thefacebook.com>
On Tue, Aug 27, 2024 at 09:42:08AM -0600, Keith Busch wrote:
> On Tue, Aug 27, 2024 at 12:17:01PM +0000, Puranjay Mohan wrote:
> > @@ -122,6 +123,9 @@ static int nvme_map_user_request(struct request *req, u64 ubuffer,
> > struct bio *bio = NULL;
> > int ret;
> >
> > + if (meta_buffer && meta_len && bdev && !blk_get_integrity(bdev->bd_disk))
> > + return -EINVAL;
> > +
>
> Should we also fail if there's no bdev? The driver won't use the
> requested metadata for admin commands either, so that is also an invalid
> user request.
Yes, the last version gets the right.
prev parent reply other threads:[~2024-08-28 4:29 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-08-27 12:17 [PATCH] nvme: check if the namespace supports metadata in nvme_map_user_request() Puranjay Mohan
2024-08-27 12:19 ` Christoph Hellwig
2024-08-27 12:28 ` Puranjay Mohan
2024-09-06 18:07 ` Keith Busch
2024-08-27 15:42 ` Keith Busch
2024-08-28 4:29 ` Christoph Hellwig [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20240828042915.GB30879@lst.de \
--to=hch@lst.de \
--cc=axboe@kernel.dk \
--cc=kbusch@kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-nvme@lists.infradead.org \
--cc=pjy@amazon.com \
--cc=puranjay@kernel.org \
--cc=sagi@grimberg.me \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox