Re: [PATCH v5 3/5] fcntl: add F_{SET/GET}_RW_HINT_EX

Kanchan Joshi
2024-09-11T15:55:24Z

On 9/11/2024 12:18 AM, Jens Axboe wrote:
> On 9/10/24 9:01 AM, Kanchan Joshi wrote:
>> +static inline bool rw_placement_hint_valid(u64 val)
>> +{
>> + if (val <= MAX_PLACEMENT_HINT_VAL)
>> + return true;
>> +
>> + return false;
>> +}
> Nit, why not just:
>
> static inline bool rw_placement_hint_valid(u64 val)
> {
> return val <= MAX_PLACEMENT_HINT_VAL;
> }
>

Right, concise.
I can fold in both the changes in next respin.