From: Christoph Hellwig <hch@lst.de>
To: Greg Joyce <gjoyce@linux.ibm.com>
Cc: Christoph Hellwig <hch@lst.de>,
linux-nvme@lists.infradead.org, kbusch@kernel.org, axboe@fb.com,
sagi@grimberg.me, hare@suse.de, dwagner@suse.de,
msuchanek@suse.de, jonathan.derrick@linux.dev,
okozina@redhat.com, nilay@linux.ibm.com
Subject: Re: [PATCH 1/1] nvme: retry security commands if media not ready
Date: Thu, 3 Oct 2024 16:41:06 +0200 [thread overview]
Message-ID: <20241003144106.GA24422@lst.de> (raw)
In-Reply-To: <3876a795bbaa8cef46ed0cb84f8eeccc5462f075.camel@linux.ibm.com>
On Thu, Oct 03, 2024 at 08:30:21AM -0500, Greg Joyce wrote:
> Thanks. I think that leads me to ask a larger question. If we always
> wait until media ready,
We don't generally wait - the namespaces only become online when they
are ready, but otherwise we should be up. Unfortunately the technical
working group allowed some admin command to return media not ready,
probably to shoe horn existing implementation. But this generally
is a bad quality of implementation and there is no good reason for it
if the little bit of media used by these comes from a separate pool
that doesn't take as long to recover. Or in other words, if you see
this error someonone at IBM messed up writing their purchase spec..
next prev parent reply other threads:[~2024-10-03 14:41 UTC|newest]
Thread overview: 11+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-09-30 16:48 [PATCH 0/1] nvme: add retry for media not ready error gjoyce
2024-09-30 16:48 ` [PATCH 1/1] nvme: retry security commands if media not ready gjoyce
2024-10-02 8:16 ` Christoph Hellwig
2024-10-02 16:51 ` Greg Joyce
2024-10-03 12:43 ` Christoph Hellwig
2024-10-03 13:30 ` Greg Joyce
2024-10-03 14:41 ` Christoph Hellwig [this message]
2024-10-03 23:35 ` Greg Joyce
2024-10-04 5:41 ` Christoph Hellwig
2024-10-04 7:22 ` Nilay Shroff
2024-10-04 12:24 ` Christoph Hellwig
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20241003144106.GA24422@lst.de \
--to=hch@lst.de \
--cc=axboe@fb.com \
--cc=dwagner@suse.de \
--cc=gjoyce@linux.ibm.com \
--cc=hare@suse.de \
--cc=jonathan.derrick@linux.dev \
--cc=kbusch@kernel.org \
--cc=linux-nvme@lists.infradead.org \
--cc=msuchanek@suse.de \
--cc=nilay@linux.ibm.com \
--cc=okozina@redhat.com \
--cc=sagi@grimberg.me \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox