Linux-NVME Archive on lore.kernel.org
 help / color / mirror / Atom feed
From: Dmitry Bogdanov <d.bogdanov@yadro.com>
To: Guixin Liu <kanie@linux.alibaba.com>
Cc: <hch@lst.de>, <sagi@grimberg.me>, <kch@nvidia.com>,
	<linux-nvme@lists.infradead.org>
Subject: Re: [PATCH v14 2/2] nvmet: support reservation feature
Date: Fri, 11 Oct 2024 10:48:37 +0300	[thread overview]
Message-ID: <20241011074837.GM22571@yadro.com> (raw)
In-Reply-To: <20241011022612.50303-3-kanie@linux.alibaba.com>

On Fri, Oct 11, 2024 at 10:26:12AM +0800, Guixin Liu wrote:
> 
> This patch implements the reservation feature, including:
>   1. reservation register(register, unregister and replace).
>   2. reservation acquire(acquire, preempt, preempt and abort).
>   3. reservation release(release and clear).
>   4. reservation report.
>   5. set feature and get feature of reservation notify mask.
>   6. get log page of reservation event.
> 
> Not supported:
>   1. persistent reservation through power loss.
> 
> Test cases:
>   Use nvme-cli and fio to test all implemented sub features:
>   1. use nvme resv-register to register host a registrant or
>      unregister or replace a new key.
>   2. use nvme resv-acquire to set host to the holder, and use fio
>      to send read and write io in all reservation type. And also
>      test preempt and "preempt and abort".
>   3. use nvme resv-report to show all registrants and reservation
>      status.
>   4. use nvme resv-release to release all registrants.
>   5. use nvme get-log to get events generated by the preceding
>      operations.
> 
> In addition, make reservation configurable, one can set ns to
> support reservation before enable ns. The default of resv_enable
> is false.
> 
> Signed-off-by: Guixin Liu <kanie@linux.alibaba.com>

Once got, you may(should for reviewers) add Revived-by tag for the
patches. So, please do not forget:

Reviwed-by: Dmitry Bogdanov <d.bogdanov@yadro.com>


  reply	other threads:[~2024-10-11  7:50 UTC|newest]

Thread overview: 13+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2024-10-11  2:26 [PATCH v14 0/2] Implement the NVMe reservation feature Guixin Liu
2024-10-11  2:26 ` [PATCH v14 1/2] nvme: add reservation command's defines Guixin Liu
2024-10-14  5:43   ` Chaitanya Kulkarni
2024-10-14  6:00     ` Guixin Liu
2024-10-11  2:26 ` [PATCH v14 2/2] nvmet: support reservation feature Guixin Liu
2024-10-11  7:48   ` Dmitry Bogdanov [this message]
2024-10-11  8:10   ` Christoph Hellwig
2024-10-14  4:04   ` Chaitanya Kulkarni
2024-10-14  5:34     ` Guixin Liu
2024-10-14  6:18       ` Chaitanya Kulkarni
2024-10-14  6:31         ` Guixin Liu
2024-10-15  5:00       ` hch
2024-10-14  6:05   ` Chaitanya Kulkarni

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20241011074837.GM22571@yadro.com \
    --to=d.bogdanov@yadro.com \
    --cc=hch@lst.de \
    --cc=kanie@linux.alibaba.com \
    --cc=kch@nvidia.com \
    --cc=linux-nvme@lists.infradead.org \
    --cc=sagi@grimberg.me \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox