Re: [PATCHv8 1/6] block, fs: restore kiocb based write hint processing

Bart Van Assche
2024-10-18T16:11:40Z

On 10/17/24 9:09 AM, Keith Busch wrote:
> diff --git a/include/linux/fs.h b/include/linux/fs.h
> index 3559446279c15..04e875a37f604 100644
> --- a/include/linux/fs.h
> +++ b/include/linux/fs.h
> @@ -370,6 +370,7 @@ struct kiocb {
> void *private;
> int ki_flags;
> u16 ki_ioprio; /* See linux/ioprio.h */
> + u16 ki_write_hint;
> union {
> /*
> * Only used for async buffered reads, where it denotes the

Why 'u16'? Shouldn't this patch use the type 'enum rw_hint' for
ki_write_hint and shouldn't this type be changed into u16 in a later patch?

Thanks,

Bart.