From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 5FDC4D3C54F for ; Fri, 18 Oct 2024 05:56:30 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender:List-Subscribe:List-Help :List-Post:List-Archive:List-Unsubscribe:List-Id:In-Reply-To:Content-Type: MIME-Version:References:Message-ID:Subject:Cc:To:From:Date:Reply-To: Content-Transfer-Encoding:Content-ID:Content-Description:Resent-Date: Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID:List-Owner; bh=oSdWWeL/QEfkDHDdx4nORYC0I6w+NFzP5tw8PPtZFas=; b=iFwuzxv4Z/Vi5D2SZ72E3WssLF bEV5ckfYKT33uDxyBNwuLp/TeNXeukJn0491KZhJn91xJvNgpsrLQMWAfPl6LhenSJLTmgIF1DvwG vrKsemAobc7/0nvc7ScmSw6D1GEQ3iR9b8rx28rPw1l0uGhw371alZlMXAyhVfrbZkWXzJye6JqRA bCWZYd5RHSdrsToJWjuqFAmeHZWSB27WfM3lz7RmKVTtPV9D0IObOUEdYnj7KYbebIl8njKVwcg8Y aOPj+7J9Hu+cGUg+36DvLK3g+Sfu4j7VWEaIPliyjvtVpoOuDArOR8xLJRmNSp6cMEBO0BxrbQYyY PN8eQc2A==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.98 #2 (Red Hat Linux)) id 1t1fyO-0000000H2kg-1hCI; Fri, 18 Oct 2024 05:56:28 +0000 Received: from verein.lst.de ([213.95.11.211]) by bombadil.infradead.org with esmtps (Exim 4.98 #2 (Red Hat Linux)) id 1t1fuU-0000000H1bq-19UZ for linux-nvme@lists.infradead.org; Fri, 18 Oct 2024 05:52:28 +0000 Received: by verein.lst.de (Postfix, from userid 2407) id 81037227AAF; Fri, 18 Oct 2024 07:52:23 +0200 (CEST) Date: Fri, 18 Oct 2024 07:52:23 +0200 From: Christoph Hellwig To: Keith Busch Cc: linux-block@vger.kernel.org, linux-nvme@lists.infradead.org, axboe@kernel.dk, hch@lst.de, io-uring@vger.kernel.org, linux-fsdevel@vger.kernel.org, joshi.k@samsung.com, javier.gonz@samsung.com, Keith Busch Subject: Re: [PATCHv8 4/6] fs: introduce per-io hint support flag Message-ID: <20241018055223.GD20262@lst.de> References: <20241017160937.2283225-1-kbusch@meta.com> <20241017160937.2283225-5-kbusch@meta.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20241017160937.2283225-5-kbusch@meta.com> User-Agent: Mutt/1.5.17 (2007-11-01) X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20241017_225226_816442_3B0D80BB X-CRM114-Status: GOOD ( 12.53 ) X-BeenThere: linux-nvme@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: "Linux-nvme" Errors-To: linux-nvme-bounces+linux-nvme=archiver.kernel.org@lists.infradead.org On Thu, Oct 17, 2024 at 09:09:35AM -0700, Keith Busch wrote: > From: Keith Busch > > A block device may support write hints on a per-io basis. The raw block > file operations can effectively use these, but real filesystems are not > ready to make use of this. Provide a file_operations flag to indicate > support, and set it for the block file operations. I'm a little worried about the overly generic "hint" think again. Make it very explicit about the write streams and this make sense.