From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id C008DD13570 for ; Mon, 28 Oct 2024 11:51:48 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender:List-Subscribe:List-Help :List-Post:List-Archive:List-Unsubscribe:List-Id:In-Reply-To:Content-Type: MIME-Version:References:Message-ID:Subject:Cc:To:From:Date:Reply-To: Content-Transfer-Encoding:Content-ID:Content-Description:Resent-Date: Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID:List-Owner; bh=vjHWBvZQjfdbHOYJbB7PIqv80EpopDFfPefTg8AB+2Y=; b=eWjvxrpPBLFcsJ+BtjFLU9u6/v 23CQYm4iX8pQBcnjifSG2tBtGciUHlECAGgS7v9fqwRba9/yuqN9CPBIauoJvVjXIQj5Tz9hEDwk7 H0YDz81RST6WCH+qYG3nJyVZ+EdGmNhMR1l8szi7dZwD2IRTZ0rGSLU9qWLQOq4ZU/doPkIbIS6BU EWrLECdVSt8mVlZRTIUdwc3PnRbeoSH/KtPM7dwIWEPKgiKgBd1fpGGqc3XuL5sgJj1zrFtiw7U50 I/RHJaohQf/TpQpbhwM1L3wrbBQfyiImN8Bm7je2KhCpZM9rodz10wTYOgrre2mKRgF6YbbG6l9Qo BPq4TT3Q==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.98 #2 (Red Hat Linux)) id 1t5OHj-0000000Ad64-1Bbx; Mon, 28 Oct 2024 11:51:47 +0000 Received: from verein.lst.de ([213.95.11.211]) by bombadil.infradead.org with esmtps (Exim 4.98 #2 (Red Hat Linux)) id 1t5OHf-0000000Ad5X-3v4C for linux-nvme@lists.infradead.org; Mon, 28 Oct 2024 11:51:45 +0000 Received: by verein.lst.de (Postfix, from userid 2407) id 12F60227AAC; Mon, 28 Oct 2024 12:51:34 +0100 (CET) Date: Mon, 28 Oct 2024 12:51:32 +0100 From: Christoph Hellwig To: Keith Busch Cc: linux-block@vger.kernel.org, linux-nvme@lists.infradead.org, linux-scsi@vger.kernel.org, io-uring@vger.kernel.org, linux-fsdevel@vger.kernel.org, hch@lst.de, joshi.k@samsung.com, javier.gonz@samsung.com, bvanassche@acm.org, Keith Busch , Hannes Reinecke Subject: Re: [PATCHv9 2/7] block: introduce max_write_hints queue limit Message-ID: <20241028115132.GB8517@lst.de> References: <20241025213645.3464331-1-kbusch@meta.com> <20241025213645.3464331-3-kbusch@meta.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20241025213645.3464331-3-kbusch@meta.com> User-Agent: Mutt/1.5.17 (2007-11-01) X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20241028_045144_132916_72A995DD X-CRM114-Status: GOOD ( 10.54 ) X-BeenThere: linux-nvme@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: "Linux-nvme" Errors-To: linux-nvme-bounces+linux-nvme=archiver.kernel.org@lists.infradead.org On Fri, Oct 25, 2024 at 02:36:40PM -0700, Keith Busch wrote: > +static inline unsigned short bdev_max_write_hints(struct block_device *bdev) > +{ > + return queue_max_write_hints(bdev_get_queue(bdev)); > +} As pointed out by Bart last time, you can't simply give the write hints to all block device. Assume we'd want to wire up the write stream based separate to f2fs (which btw would be a good demonstration), and you'd have two different f2fs file systems on separate partitions that'd now start sharing the write streams if they simply started from stream 1. Same for our pending XFS data placement work.