From: Chaitanya Kulkarni <kch@nvidia.com>
To: <kanie@linux.alibaba.com>
Cc: <linux-nvme@lists.infradead.org>, <linux-block@vger.kernel.org>,
<shinichiro.kawasaki@wdc.com>, <dwagner@suse.de>,
Chaitanya Kulkarni <kch@nvidia.com>
Subject: [PATCH] nvme: test nvmet-wq sysfs interface
Date: Mon, 4 Nov 2024 11:29:07 -0800 [thread overview]
Message-ID: <20241104192907.21358-1-kch@nvidia.com> (raw)
Add a test that randomly sets the cpumask from available CPUs for
the nvmet-wq while running the fio workload. This patch has been
tested on nvme-loop and nvme-tcp transport.
Signed-off-by: Chaitanya Kulkarni <kch@nvidia.com>
---
tests/nvme/055 | 99 ++++++++++++++++++++++++++++++++++++++++++++++
tests/nvme/055.out | 3 ++
2 files changed, 102 insertions(+)
create mode 100755 tests/nvme/055
create mode 100644 tests/nvme/055.out
diff --git a/tests/nvme/055 b/tests/nvme/055
new file mode 100755
index 0000000..9fe27a3
--- /dev/null
+++ b/tests/nvme/055
@@ -0,0 +1,99 @@
+#!/bin/bash
+# SPDX-License-Identifier: GPL-2.0+
+# Copyright (C) 2024 Chaitanya Kulkarni
+#
+# Test nvmet-wq cpumask sysfs attribute with NVMe-oF and fio workload
+#
+
+. tests/nvme/rc
+
+DESCRIPTION="Test nvmet-wq cpumask sysfs attribute with fio on NVMe-oF device"
+TIMED=1
+
+requires() {
+ _nvme_requires
+ _have_fio && _have_loop
+ _require_nvme_trtype_is_fabrics
+}
+
+cleanup_setup() {
+ _nvme_disconnect_subsys
+ _nvmet_target_cleanup
+}
+
+test() {
+ local cpumask_path="/sys/devices/virtual/workqueue/nvmet-wq/cpumask"
+ local original_cpumask
+ local min_cpus
+ local max_cpus
+ local numbers
+ local idx
+ local ns
+
+ echo "Running ${TEST_NAME}"
+
+ _setup_nvmet
+ _nvmet_target_setup
+ _nvme_connect_subsys
+
+ if [ ! -f "$cpumask_path" ]; then
+ SKIP_REASONS+=("nvmet_wq cpumask sysfs attribute not found.")
+ cleanup_setup
+ return 1
+ fi
+
+ ns=$(_find_nvme_ns "${def_subsys_uuid}")
+
+ original_cpumask=$(cat "$cpumask_path")
+
+ num_cpus=$(nproc)
+ max_cpus=$(( num_cpus < 20 ? num_cpus : 20 ))
+ min_cpus=0
+ #shellcheck disable=SC2207
+ numbers=($(seq $min_cpus $max_cpus))
+
+ _run_fio_rand_io --filename="/dev/${ns}" --time_based --runtime=130s \
+ --iodepth=8 --size="${NVME_IMG_SIZE}" &> "$FULL" &
+
+ # Let the fio settle down else we will break in the loop for fio check
+ sleep 1
+ for ((i = 0; i < max_cpus; i++)); do
+ if ! pgrep -x fio &> /dev/null ; then
+ break
+ fi
+
+ if [[ ${#numbers[@]} -eq 0 ]]; then
+ break
+ fi
+
+ idx=$((RANDOM % ${#numbers[@]}))
+
+ #shellcheck disable=SC2004
+ cpu_mask=$(printf "%X" $((1 << ${numbers[idx]})))
+ echo "$cpu_mask" > "$cpumask_path"
+ if [[ $(cat "$cpumask_path") =~ ^[0,]*${cpu_mask}\n$ ]]; then
+ echo "Test Failed: cpumask was not set correctly "
+ echo "Expected ${cpu_mask} found $(cat "$cpumask_path")"
+ cleanup_setup
+ return 1
+ fi
+ sleep 3
+ # Remove the selected number
+ numbers=("${numbers[@]:0:$idx}" "${numbers[@]:$((idx + 1))}")
+ done
+
+ killall fio &> /dev/null
+
+ # Restore original cpumask
+ echo "$original_cpumask" > "$cpumask_path"
+ restored_cpumask=$(cat "$cpumask_path")
+
+ if [[ "$restored_cpumask" != "$original_cpumask" ]]; then
+ echo "Failed to restore original cpumask."
+ cleanup_setup
+ return 1
+ fi
+
+ cleanup_setup
+ echo "Test complete"
+}
diff --git a/tests/nvme/055.out b/tests/nvme/055.out
new file mode 100644
index 0000000..427dfee
--- /dev/null
+++ b/tests/nvme/055.out
@@ -0,0 +1,3 @@
+Running nvme/055
+disconnected 1 controller(s)
+Test complete
--
2.40.0
next reply other threads:[~2024-11-04 19:34 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-11-04 19:29 Chaitanya Kulkarni [this message]
2024-11-05 7:02 ` [PATCH] nvme: test nvmet-wq sysfs interface Daniel Wagner
2024-11-06 3:46 ` Chaitanya Kulkarni
2024-11-06 12:13 ` Daniel Wagner
2024-11-08 5:00 ` Shinichiro Kawasaki
2024-11-08 5:21 ` Shinichiro Kawasaki
2024-11-12 0:58 ` Chaitanya Kulkarni
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20241104192907.21358-1-kch@nvidia.com \
--to=kch@nvidia.com \
--cc=dwagner@suse.de \
--cc=kanie@linux.alibaba.com \
--cc=linux-block@vger.kernel.org \
--cc=linux-nvme@lists.infradead.org \
--cc=shinichiro.kawasaki@wdc.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox