From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 411AED2B92E for ; Tue, 5 Nov 2024 13:58:28 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender:List-Subscribe:List-Help :List-Post:List-Archive:List-Unsubscribe:List-Id:In-Reply-To:Content-Type: MIME-Version:References:Message-ID:Subject:Cc:To:From:Date:Reply-To: Content-Transfer-Encoding:Content-ID:Content-Description:Resent-Date: Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID:List-Owner; bh=zGp4IXZViaWgWJjpSWy64E6gS/PdB9HvtP630dbNegI=; b=F7dOTdG6ji+T/RXT8SaSP8BepJ 0IxMMYKUd1dnIgeSir/Z3oEpLdUuLi++jFbQYCUvDkFUmqz25A65TdAuAlAfKCBkh27lPVRERWPCz ZdYOQ2Kv+UimCHFnAHyEBbDKUs6HFV65kmlCcO4TWfg6LyARHuHIK32mjs/NIvLA0rHx6NkDtAtwk ZBaRTSmMMrkH1BY1wdqLxLEJm/DeyFa2126VW8qAJ35Z4eJM+WnGfkaW8WIW36MPjO/KHkR/7s6tT V1K6xC0d+D8dxBYQ9X4zP14vUobt2vTbQqF3dpcEdrGSyOrLd36vV/PhLKHYDILvQpuamdpBMKtAP evk6Reeg==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.98 #2 (Red Hat Linux)) id 1t8K4f-0000000HBsh-0axY; Tue, 05 Nov 2024 13:58:25 +0000 Received: from verein.lst.de ([213.95.11.211]) by bombadil.infradead.org with esmtps (Exim 4.98 #2 (Red Hat Linux)) id 1t8K3M-0000000HBib-1g4u for linux-nvme@lists.infradead.org; Tue, 05 Nov 2024 13:57:06 +0000 Received: by verein.lst.de (Postfix, from userid 2407) id E87FE68CFE; Tue, 5 Nov 2024 14:56:57 +0100 (CET) Date: Tue, 5 Nov 2024 14:56:57 +0100 From: Christoph Hellwig To: Anuj gupta Cc: Christoph Hellwig , Anuj Gupta , axboe@kernel.dk, kbusch@kernel.org, martin.petersen@oracle.com, asml.silence@gmail.com, brauner@kernel.org, jack@suse.cz, viro@zeniv.linux.org.uk, io-uring@vger.kernel.org, linux-nvme@lists.infradead.org, linux-block@vger.kernel.org, gost.dev@samsung.com, linux-scsi@vger.kernel.org, vishak.g@samsung.com, linux-fsdevel@vger.kernel.org, Kanchan Joshi Subject: Re: [PATCH v7 06/10] io_uring/rw: add support to send metadata along with read/write Message-ID: <20241105135657.GA4775@lst.de> References: <20241104140601.12239-1-anuj20.g@samsung.com> <20241104140601.12239-7-anuj20.g@samsung.com> <20241105095621.GB597@lst.de> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: User-Agent: Mutt/1.5.17 (2007-11-01) X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20241105_055704_598941_253CC30B X-CRM114-Status: GOOD ( 13.32 ) X-BeenThere: linux-nvme@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: "Linux-nvme" Errors-To: linux-nvme-bounces+linux-nvme=archiver.kernel.org@lists.infradead.org On Tue, Nov 05, 2024 at 06:34:29PM +0530, Anuj gupta wrote: > The field is used only at io_uring level, and it helps there in using the > SQE space flexibly. How so? There is absolutely no documentation for it in either the code or commit log. And if it is about sqe space management, meta_type is about the most confusing possible name as well. So someone please needs to write down how it is supposed to work and come up with a name that remotely makes sense for that.