From: Christoph Hellwig <hch@lst.de>
To: "brookxu.cn" <brookxu.cn@gmail.com>
Cc: kbusch@kernel.org, axboe@kernel.dk, hch@lst.de, sagi@grimberg.me,
linux-nvme@lists.infradead.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH v2] nvme-core: auto add the new ns while UUID changed
Date: Fri, 15 Nov 2024 18:04:11 +0100 [thread overview]
Message-ID: <20241115170411.GA23437@lst.de> (raw)
In-Reply-To: <20241115083727.30005-1-brookxu.cn@gmail.com>
On Fri, Nov 15, 2024 at 04:37:27PM +0800, brookxu.cn wrote:
> From: "Chunguang.xu" <chunguang.xu@shopee.com>
>
> Now spdk will change UUID of ns while restarted if we have not
> specified one. At this time, while host try to reconnected to target,
> as UUID have changed, we will remove the old ns, but not add the ns
> with the new UUID.
And that is broken behavior. The host must assume the namespace has
been deleted and recreated when the eui/nguid/uuid change, and we need
to catch this. Fix your broken target code instead.
next prev parent reply other threads:[~2024-11-15 17:04 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-11-15 8:37 [PATCH v2] nvme-core: auto add the new ns while UUID changed brookxu.cn
2024-11-15 17:04 ` Christoph Hellwig [this message]
2024-11-16 0:49 ` 许春光
2024-11-18 6:26 ` Christoph Hellwig
2024-11-18 9:31 ` 许春光
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20241115170411.GA23437@lst.de \
--to=hch@lst.de \
--cc=axboe@kernel.dk \
--cc=brookxu.cn@gmail.com \
--cc=kbusch@kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-nvme@lists.infradead.org \
--cc=sagi@grimberg.me \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox