Re: [PATCHv3 3/3] nvme-pci: use sgls for all user requests if possible

Christoph Hellwig
2024-11-18T16:28:57Z

On Mon, Nov 18, 2024 at 07:57:38AM -0800, Keith Busch wrote:
> From: Keith Busch <kbusch@kernel.org>
>
> If the device supports SGLs, use these for all user requests. This
> format encodes the expected transfer length so it can catch short buffer
> errors in a user command, whether it occurred accidently or maliciously.
>
> For controllers that support SGL data mode, this is a viable mitigation
> to CVE-2023-6238. For controllers that don't support SGL, log a warning
> in the passthrough path since not having the capability can corrupt
> data if the interface is not use correctly.

Looks good:

Reviewed-by: Christoph Hellwig <hch@lst.de>