From: Christoph Hellwig <hch@lst.de>
To: Guixin Liu <kanie@linux.alibaba.com>
Cc: Keith Busch <kbusch@kernel.org>, Jens Axboe <axboe@kernel.dk>,
Christoph Hellwig <hch@lst.de>, Sagi Grimberg <sagi@grimberg.me>,
linux-nvme@lists.infradead.org
Subject: Re: [PATCH] nvme: tuning pr code by using defined structs and macros
Date: Tue, 19 Nov 2024 17:21:12 +0100 [thread overview]
Message-ID: <20241119162112.GB14774@lst.de> (raw)
In-Reply-To: <20241119102925.128435-1-kanie@linux.alibaba.com>
On Tue, Nov 19, 2024 at 06:29:25PM +0800, Guixin Liu wrote:
> All the modifications are simply to make the code more readable,
> and this patch does not include any functional changes.
>
> Signed-off-by: Guixin Liu <kanie@linux.alibaba.com>
> ---
> drivers/nvme/host/pr.c | 125 +++++++++++++++++++++++++----------------
> 1 file changed, 78 insertions(+), 47 deletions(-)
>
> diff --git a/drivers/nvme/host/pr.c b/drivers/nvme/host/pr.c
> index dc7922f22600..3fd292badd42 100644
> --- a/drivers/nvme/host/pr.c
> +++ b/drivers/nvme/host/pr.c
> @@ -9,6 +9,9 @@
>
> #include "nvme.h"
>
> +#define NVME_PR_SET_PTPL_TO_PERSIST ((1 << 30) | (1 << 31))
> +#define NVME_PR_IGNORE_KEY (1 << 3)
Normally definitions should go into linux/nvme.h. I'd also
normally expect the different CPTPL bits to be defined separately.
next prev parent reply other threads:[~2024-11-19 16:21 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-11-19 10:29 [PATCH] nvme: tuning pr code by using defined structs and macros Guixin Liu
2024-11-19 16:21 ` Christoph Hellwig [this message]
2024-11-20 1:48 ` Guixin Liu
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20241119162112.GB14774@lst.de \
--to=hch@lst.de \
--cc=axboe@kernel.dk \
--cc=kanie@linux.alibaba.com \
--cc=kbusch@kernel.org \
--cc=linux-nvme@lists.infradead.org \
--cc=sagi@grimberg.me \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox