From: Nitesh Shetty <nj.shetty@samsung.com>
To: Christoph Hellwig <hch@lst.de>
Cc: kbusch@kernel.org, sagi@grimberg.me, axboe@kernel.dk,
linux-nvme@lists.infradead.org,
Saeed Mirzamohammadi <saeed.mirzamohammadi@oracle.com>
Subject: Re: [PATCH] nvme: don't apply NVME_QUIRK_DEALLOCATE_ZEROES when DSM is not supported
Date: Wed, 27 Nov 2024 20:50:54 +0530 [thread overview]
Message-ID: <20241127152044.4lyezvphq5szu5f2@ubuntu> (raw)
In-Reply-To: <20241127064218.42688-1-hch@lst.de>
[-- Attachment #1: Type: text/plain, Size: 830 bytes --]
On 27/11/24 07:42AM, Christoph Hellwig wrote:
>Commit 63dfa1004322 ("nvme: move NVME_QUIRK_DEALLOCATE_ZEROES out of
>nvme_config_discard") started applying the NVME_QUIRK_DEALLOCATE_ZEROES
>quirk even then the Dataset Management is not supported. It turns out
>that there versions of these old Intel SSDs that have DSM support
>disabled in the firmware, which will now lead to errors everytime
>a Write Zeroes command is issued. Fix this by checking for DSM support
>before applying the quirk.
>
>Reported-by: Saeed Mirzamohammadi <saeed.mirzamohammadi@oracle.com>
>Fixes: 63dfa1004322 ("nvme: move NVME_QUIRK_DEALLOCATE_ZEROES out of nvme_config_discard")
>Tested-by: Saeed Mirzamohammadi <saeed.mirzamohammadi@oracle.com>
>Signed-off-by: Christoph Hellwig <hch@lst.de>
>---
Reviewed-by: Nitesh Shetty <nj.shetty@samsung.com>
[-- Attachment #2: Type: text/plain, Size: 0 bytes --]
next prev parent reply other threads:[~2024-11-27 15:59 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
[not found] <CGME20241127152849epcas5p3872af708d33fbfb00fd3b703b879b273@epcas5p3.samsung.com>
2024-11-27 6:42 ` [PATCH] nvme: don't apply NVME_QUIRK_DEALLOCATE_ZEROES when DSM is not supported Christoph Hellwig
2024-11-27 7:48 ` Chaitanya Kulkarni
2024-11-27 15:20 ` Nitesh Shetty [this message]
2024-11-27 15:45 ` Keith Busch
2024-11-27 15:48 ` Christoph Hellwig
2024-11-27 15:52 ` Keith Busch
2024-12-02 17:54 ` Keith Busch
2024-12-02 18:03 ` Saeed Mirzamohammadi
2024-12-02 18:08 ` Keith Busch
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20241127152044.4lyezvphq5szu5f2@ubuntu \
--to=nj.shetty@samsung.com \
--cc=axboe@kernel.dk \
--cc=hch@lst.de \
--cc=kbusch@kernel.org \
--cc=linux-nvme@lists.infradead.org \
--cc=saeed.mirzamohammadi@oracle.com \
--cc=sagi@grimberg.me \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox