Re: [PATCH] nvme: don't apply NVME_QUIRK_DEALLOCATE_ZEROES when DSM is not supported

Christoph Hellwig
2024-11-27T15:48:24Z

On Wed, Nov 27, 2024 at 08:45:04AM -0700, Keith Busch wrote:
> I still think this is wrong, and we should just remove the quirk for
> this device. With the exception to this firmware version, this device
> generally supports both discards and write zeroes. The only reason it
> added this quirk was because the quirk used to mean something completely
> different (specifically, it would set the "discard_zeroes_data"
> attribute that's no longer used). It didn't mean to prefer discards over
> write zeroes, but that's what it means now, and that's not what this
> drive wants.

I'll have to trust you on this device, and certainly won't object
removing this weirdo quick. But as long as we don't remove the
quirk entirely we'll also need this fix. So I guess we should go
for both?