Re: [PATCH] nvme: don't apply NVME_QUIRK_DEALLOCATE_ZEROES when DSM is not supported

Nitesh Shetty
2024-11-27T15:59:42Z

[-- Attachment #1: Type: text/plain, Size: 830 bytes --]

On 27/11/24 07:42AM, Christoph Hellwig wrote:
>Commit 63dfa1004322 ("nvme: move NVME_QUIRK_DEALLOCATE_ZEROES out of
>nvme_config_discard") started applying the NVME_QUIRK_DEALLOCATE_ZEROES
>quirk even then the Dataset Management is not supported. It turns out
>that there versions of these old Intel SSDs that have DSM support
>disabled in the firmware, which will now lead to errors everytime
>a Write Zeroes command is issued. Fix this by checking for DSM support
>before applying the quirk.
>
>Reported-by: Saeed Mirzamohammadi <saeed.mirzamohammadi@oracle.com>
>Fixes: 63dfa1004322 ("nvme: move NVME_QUIRK_DEALLOCATE_ZEROES out of nvme_config_discard")
>Tested-by: Saeed Mirzamohammadi <saeed.mirzamohammadi@oracle.com>
>Signed-off-by: Christoph Hellwig <hch@lst.de>
>---

Reviewed-by: Nitesh Shetty <nj.shetty@samsung.com>

[-- Attachment #2: Type: text/plain, Size: 0 bytes --]