Re: [PATCH] nvme: don't apply NVME_QUIRK_DEALLOCATE_ZEROES when DSM is not supported

Saeed Mirzamohammadi
2024-12-02T18:03:51Z

Thanks! Can this be applied to 6.11+ stable releases as well since the broken commit is in 6.9.y?

Saeed

> On Dec 2, 2024, at 9:54 AM, Keith Busch <kbusch@kernel.org> wrote:
>
> On Wed, Nov 27, 2024 at 07:42:18AM +0100, Christoph Hellwig wrote:
>> Commit 63dfa1004322 ("nvme: move NVME_QUIRK_DEALLOCATE_ZEROES out of
>> nvme_config_discard") started applying the NVME_QUIRK_DEALLOCATE_ZEROES
>> quirk even then the Dataset Management is not supported. It turns out
>> that there versions of these old Intel SSDs that have DSM support
>> disabled in the firmware, which will now lead to errors everytime
>> a Write Zeroes command is issued. Fix this by checking for DSM support
>> before applying the quirk.
>>
>> Reported-by: Saeed Mirzamohammadi <saeed.mirzamohammadi@oracle.com>
>> Fixes: 63dfa1004322 ("nvme: move NVME_QUIRK_DEALLOCATE_ZEROES out of nvme_config_discard")
>> Tested-by: Saeed Mirzamohammadi <saeed.mirzamohammadi@oracle.com>
>> Signed-off-by: Christoph Hellwig <hch@lst.de>
>
> Thanks, applied to nvme-6.13.