From: Christoph Hellwig <hch@lst.de>
To: Maurizio Lombardi <mlombard@redhat.com>
Cc: kbusch@kernel.org, axboe@kernel.dk, hch@lst.de, sagi@grimberg.me,
linux-nvme@lists.infradead.org, kanie@linux.alibaba.com,
kch@nvidia.com, loberman@redhat.com, emilne@redhat.com,
jmeneghi@redhat.com
Subject: Re: [PATCH] nvme-fabrics: handle zero MAXCMD without closing the connection
Date: Tue, 3 Dec 2024 01:36:07 +0100 [thread overview]
Message-ID: <20241203003607.GA7439@lst.de> (raw)
In-Reply-To: <20241129141706.261171-1-mlombard@redhat.com>
On Fri, Nov 29, 2024 at 03:17:06PM +0100, Maurizio Lombardi wrote:
> The NVMe specification states that MAXCMD is mandatory
> for NVMe-over-Fabrics implementations. However, some NVMe/TCP
> and NVMe/FC arrays from major vendors have buggy firmware
> that reports MAXCMD as zero in the Identify Controller data structure.
Sigh.
> if (!ctrl->maxcmd) {
> - dev_err(ctrl->device, "Maximum outstanding commands is 0\n");
> - return -EINVAL;
> + dev_err(ctrl->device,
> + "Firmware bug: maximum outstanding commands is 0\n");
> + ctrl->maxcmd = ctrl->sqsize + 1;
Maybe warn instead of err as made it not an error now? Otherwise
looks fine.
prev parent reply other threads:[~2024-12-03 0:36 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-11-29 14:17 [PATCH] nvme-fabrics: handle zero MAXCMD without closing the connection Maurizio Lombardi
2024-11-29 18:39 ` Laurence Oberman
2024-12-03 0:36 ` Christoph Hellwig [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20241203003607.GA7439@lst.de \
--to=hch@lst.de \
--cc=axboe@kernel.dk \
--cc=emilne@redhat.com \
--cc=jmeneghi@redhat.com \
--cc=kanie@linux.alibaba.com \
--cc=kbusch@kernel.org \
--cc=kch@nvidia.com \
--cc=linux-nvme@lists.infradead.org \
--cc=loberman@redhat.com \
--cc=mlombard@redhat.com \
--cc=sagi@grimberg.me \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox