From: Christoph Hellwig <hch@lst.de>
To: Nilay Shroff <nilay@linux.ibm.com>
Cc: linux-nvme@lists.infradead.org, shinichiro.kawasaki@wdc.com,
hch@lst.de, kbusch@kernel.org, sagi@grimberg.me, axboe@kernel.dk,
chaitanyak@nvidia.com, gjoyce@linux.ibm.com
Subject: Re: [PATCH] nvmet-loop: avoid using mutex in IO hotpath
Date: Mon, 9 Dec 2024 09:01:59 +0100 [thread overview]
Message-ID: <20241209080159.GA24776@lst.de> (raw)
In-Reply-To: <20241129104838.3015665-1-nilay@linux.ibm.com>
On Fri, Nov 29, 2024 at 04:18:33PM +0530, Nilay Shroff wrote:
> - xa_for_each(&ctrl->subsys->namespaces, idx, ns) {
> + xa_for_each_marked(&ctrl->subsys->namespaces, idx,
> + ns, NVMET_NS_ENABLED) {
Given that this is duplicated quite a bit, maybe add a
nvmet_for_each_enabled_ns wrapper for it? And also a nvmet_for_each_ns
one that iterates all namespaces?
Otherwise this looks good, and I really like the use of the xarray
mark to simplify things!
next prev parent reply other threads:[~2024-12-09 8:08 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-11-29 10:48 [PATCH] nvmet-loop: avoid using mutex in IO hotpath Nilay Shroff
2024-12-03 8:38 ` Hannes Reinecke
2024-12-03 8:45 ` Chaitanya Kulkarni
2024-12-09 8:01 ` Christoph Hellwig [this message]
2024-12-09 17:37 ` Nilay Shroff
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20241209080159.GA24776@lst.de \
--to=hch@lst.de \
--cc=axboe@kernel.dk \
--cc=chaitanyak@nvidia.com \
--cc=gjoyce@linux.ibm.com \
--cc=kbusch@kernel.org \
--cc=linux-nvme@lists.infradead.org \
--cc=nilay@linux.ibm.com \
--cc=sagi@grimberg.me \
--cc=shinichiro.kawasaki@wdc.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox