From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 83EB1E77182 for ; Tue, 10 Dec 2024 09:37:57 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender:List-Subscribe:List-Help :List-Post:List-Archive:List-Unsubscribe:List-Id:Content-Transfer-Encoding: MIME-Version:References:In-Reply-To:Message-ID:Date:Subject:Cc:To:From: Reply-To:Content-Type:Content-ID:Content-Description:Resent-Date:Resent-From: Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID:List-Owner; bh=zFciKeYuX0c1ByKF4pK4a5Ma26c5HcwFuNkLa0zB1NU=; b=JXQnT3MvpJJu8faOrZHu26JWHb 1Q+LrQkj6jQlYf3tNhU8gBqmY+VlgMCP5VdojS5JIVpB7yjBnKoRknK56dm5IPTR3PbW01V9KPMf/ rblhnXWfwU2icAoIXiUvtr53ltPgKwxZhIAgtJ8dfTekCfx9ceNzEURt0bK+UtBApE3XXTtfAQxKo S4KkgkaJF6Yosn16xhOI0xPrVrg7n3yL0gFrSGU9WZjV51h0MjGMdlW9qTFEEizV+6t3Y/a5IRJb/ vXJ1iTJbT6THCd7ovLS9Ryde9a5A3eb9XMHAzgeAzAiIAtYJ2Pav8poSditD57wQTfJ4WuFBdbCzx KSg3aItA==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.98 #2 (Red Hat Linux)) id 1tKwgl-0000000Avb6-3c44; Tue, 10 Dec 2024 09:37:55 +0000 Received: from nyc.source.kernel.org ([2604:1380:45d1:ec00::3]) by bombadil.infradead.org with esmtps (Exim 4.98 #2 (Red Hat Linux)) id 1tKwdg-0000000AuOC-0VYk for linux-nvme@lists.infradead.org; Tue, 10 Dec 2024 09:34:45 +0000 Received: from smtp.kernel.org (transwarp.subspace.kernel.org [100.75.92.58]) by nyc.source.kernel.org (Postfix) with ESMTP id 004B4A40DA4; Tue, 10 Dec 2024 09:32:52 +0000 (UTC) Received: by smtp.kernel.org (Postfix) with ESMTPSA id 33A87C4CEE4; Tue, 10 Dec 2024 09:34:41 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1733823283; bh=L4TUu+qtqsgC9jpXKIPNTrbBpIS2hOuPcFK8PMS9V6U=; h=From:To:Cc:Subject:Date:In-Reply-To:References:From; b=KDI6fJnflJ4/k65Wj/KqpjaRx5WZ599uYCDTVZVLOkzrlmdGGL54BzYEQAw81skTt y1h7VIB6BjxT9GtU8SdiTqBMzz1tMlTru+LY6jf2O7WETwVBeTnOe0R7uIKUUeSW3A 1P8U5LAJcOCz5KC6OY8shhJph2wXE/sLDdkTDeS1g1oVf2+H6+oO+as+/tbJ4TfmxW JF0owterC1RKJux3TCvA4pkCAweH0hssifUQSSfR5h+mD+9S8p0C1or56jGQaV924y oHATuYJv+MRJv9FmyhO3Q143NphbKqz+OkavXr+pDFH4h00oHp+SjWn3r7SOwqttoL oQGWrJ37YfLvg== From: Damien Le Moal To: linux-nvme@lists.infradead.org, Christoph Hellwig , Keith Busch , Sagi Grimberg , linux-pci@vger.kernel.org, Manivannan Sadhasivam , =?UTF-8?q?Krzysztof=20Wilczy=C5=84ski?= , Kishon Vijay Abraham I , Bjorn Helgaas , Lorenzo Pieralisi Cc: Rick Wertenbroek , Niklas Cassel Subject: [PATCH v3 03/17] nvmet: Introduce nvmet_get_cmd_effects_admin() Date: Tue, 10 Dec 2024 18:33:54 +0900 Message-ID: <20241210093408.105867-4-dlemoal@kernel.org> X-Mailer: git-send-email 2.47.1 In-Reply-To: <20241210093408.105867-1-dlemoal@kernel.org> References: <20241210093408.105867-1-dlemoal@kernel.org> MIME-Version: 1.0 Content-Transfer-Encoding: 8bit X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20241210_013444_220949_D2902790 X-CRM114-Status: GOOD ( 10.12 ) X-BeenThere: linux-nvme@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: "Linux-nvme" Errors-To: linux-nvme-bounces+linux-nvme=archiver.kernel.org@lists.infradead.org In order to have a logically better organized implementation of the effects log page, split out reporting the supported admin commands from nvmet_get_cmd_effects_nvm() into the new function nvmet_get_cmd_effects_admin(). Signed-off-by: Damien Le Moal --- drivers/nvme/target/admin-cmd.c | 7 ++++++- 1 file changed, 6 insertions(+), 1 deletion(-) diff --git a/drivers/nvme/target/admin-cmd.c b/drivers/nvme/target/admin-cmd.c index b73f5fde4d9e..78478a4a2e4d 100644 --- a/drivers/nvme/target/admin-cmd.c +++ b/drivers/nvme/target/admin-cmd.c @@ -230,7 +230,7 @@ static void nvmet_execute_get_log_page_smart(struct nvmet_req *req) nvmet_req_complete(req, status); } -static void nvmet_get_cmd_effects_nvm(struct nvme_effects_log *log) +static void nvmet_get_cmd_effects_admin(struct nvme_effects_log *log) { log->acs[nvme_admin_get_log_page] = log->acs[nvme_admin_identify] = @@ -240,7 +240,10 @@ static void nvmet_get_cmd_effects_nvm(struct nvme_effects_log *log) log->acs[nvme_admin_async_event] = log->acs[nvme_admin_keep_alive] = cpu_to_le32(NVME_CMD_EFFECTS_CSUPP); +} +static void nvmet_get_cmd_effects_nvm(struct nvme_effects_log *log) +{ log->iocs[nvme_cmd_read] = log->iocs[nvme_cmd_flush] = log->iocs[nvme_cmd_dsm] = @@ -276,6 +279,7 @@ static void nvmet_execute_get_log_cmd_effects_ns(struct nvmet_req *req) switch (req->cmd->get_log_page.csi) { case NVME_CSI_NVM: + nvmet_get_cmd_effects_admin(log); nvmet_get_cmd_effects_nvm(log); break; case NVME_CSI_ZNS: @@ -283,6 +287,7 @@ static void nvmet_execute_get_log_cmd_effects_ns(struct nvmet_req *req) status = NVME_SC_INVALID_IO_CMD_SET; goto free; } + nvmet_get_cmd_effects_admin(log); nvmet_get_cmd_effects_nvm(log); nvmet_get_cmd_effects_zns(log); break; -- 2.47.1