Re: [PATCHv13 10/11] nvme: register fdp parameters with the block layer

kernel test robot
2024-12-11T14:41:38Z

Hi Keith,

kernel test robot noticed the following build warnings:

[auto build test WARNING on axboe-block/for-next]
[also build test WARNING on next-20241211]
[cannot apply to brauner-vfs/vfs.all hch-configfs/for-next linus/master v6.13-rc2]
[If your patch is applied to the wrong git tree, kindly drop us a note.
And when submitting patch, we suggest to use '--base' as documented in
https://git-scm.com/docs/git-format-patch#_base_tree_information]

url: https://github.com/intel-lab-lkp/linux/commits/Keith-Busch/fs-add-a-write-stream-field-to-the-kiocb/20241211-080803
base: https://git.kernel.org/pub/scm/linux/kernel/git/axboe/linux-block.git for-next
patch link: https://lore.kernel.org/r/20241210194722.1905732-11-kbusch%40meta.com
patch subject: [PATCHv13 10/11] nvme: register fdp parameters with the block layer
config: i386-buildonly-randconfig-002-20241211 (https://download.01.org/0day-ci/archive/20241211/202412112244.XIKhzaWR-lkp@intel.com/config)
compiler: gcc-11 (Debian 11.3.0-12) 11.3.0
reproduce (this is a W=1 build): (https://download.01.org/0day-ci/archive/20241211/202412112244.XIKhzaWR-lkp@intel.com/reproduce)

If you fix the issue in a separate patch/commit (i.e. not just a new version of
the same patch/commit), kindly add following tags
| Reported-by: kernel test robot <lkp@intel.com>
| Closes: https://lore.kernel.org/oe-kbuild-all/202412112244.XIKhzaWR-lkp@intel.com/

All warnings (new ones prefixed by >>):

In file included from include/linux/device.h:15,
from include/linux/async.h:14,
from drivers/nvme/host/core.c:7:
drivers/nvme/host/core.c: In function 'nvme_query_fdp_granularity':
>> drivers/nvme/host/core.c:2176:26: warning: format '%lu' expects argument of type 'long unsigned int', but argument 3 has type 'size_t' {aka 'unsigned int'} [-Wformat=]
2176 | "failed to allocate %lu bytes for FDP config log\n",
| ^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
include/linux/dev_printk.h:110:30: note: in definition of macro 'dev_printk_index_wrap'
110 | _p_func(dev, fmt, ##__VA_ARGS__); \
| ^~~
include/linux/dev_printk.h:156:61: note: in expansion of macro 'dev_fmt'
156 | dev_printk_index_wrap(_dev_warn, KERN_WARNING, dev, dev_fmt(fmt), ##__VA_ARGS__)
| ^~~~~~~
drivers/nvme/host/core.c:2175:17: note: in expansion of macro 'dev_warn'
2175 | dev_warn(ctrl->device,
| ^~~~~~~~
drivers/nvme/host/core.c:2176:48: note: format string is defined here
2176 | "failed to allocate %lu bytes for FDP config log\n",
| ~~^
| |
| long unsigned int
| %u
In file included from include/linux/device.h:15,
from include/linux/async.h:14,
from drivers/nvme/host/core.c:7:
drivers/nvme/host/core.c: In function 'nvme_query_fdp_info':
drivers/nvme/host/core.c:2254:26: warning: format '%lu' expects argument of type 'long unsigned int', but argument 3 has type 'size_t' {aka 'unsigned int'} [-Wformat=]
2254 | "failed to allocate %lu bytes for FDP io-mgmt\n",
| ^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
include/linux/dev_printk.h:110:30: note: in definition of macro 'dev_printk_index_wrap'
110 | _p_func(dev, fmt, ##__VA_ARGS__); \
| ^~~
include/linux/dev_printk.h:156:61: note: in expansion of macro 'dev_fmt'
156 | dev_printk_index_wrap(_dev_warn, KERN_WARNING, dev, dev_fmt(fmt), ##__VA_ARGS__)
| ^~~~~~~
drivers/nvme/host/core.c:2253:17: note: in expansion of macro 'dev_warn'
2253 | dev_warn(ctrl->device,
| ^~~~~~~~
drivers/nvme/host/core.c:2254:48: note: format string is defined here
2254 | "failed to allocate %lu bytes for FDP io-mgmt\n",
| ~~^
| |
| long unsigned int
| %u

vim +2176 drivers/nvme/host/core.c

2153
2154 static int nvme_query_fdp_granularity(struct nvme_ctrl *ctrl,
2155 struct nvme_ns_info *info, u8 fdp_idx)
2156 {
2157 struct nvme_fdp_config_log hdr, *h;
2158 struct nvme_fdp_config_desc *desc;
2159 size_t size = sizeof(hdr);
2160 int i, n, ret;
2161 void *log;
2162
2163 ret = nvme_get_log_lsi(ctrl, 0, NVME_LOG_FDP_CONFIGS, 0,
2164 NVME_CSI_NVM, &hdr, size, 0, info->endgid);
2165 if (ret) {
2166 dev_warn(ctrl->device,
2167 "FDP configs log header status:0x%x endgid:%x\n", ret,
2168 info->endgid);
2169 return ret;
2170 }
2171
2172 size = le32_to_cpu(hdr.sze);
2173 h = kzalloc(size, GFP_KERNEL);
2174 if (!h) {
2175 dev_warn(ctrl->device,
> 2176 "failed to allocate %lu bytes for FDP config log\n",
2177 size);
2178 return -ENOMEM;
2179 }
2180
2181 ret = nvme_get_log_lsi(ctrl, 0, NVME_LOG_FDP_CONFIGS, 0,
2182 NVME_CSI_NVM, h, size, 0, info->endgid);
2183 if (ret) {
2184 dev_warn(ctrl->device,
2185 "FDP configs log status:0x%x endgid:%x\n", ret,
2186 info->endgid);
2187 goto out;
2188 }
2189
2190 n = le16_to_cpu(h->numfdpc) + 1;
2191 if (fdp_idx > n) {
2192 dev_warn(ctrl->device, "FDP index:%d out of range:%d\n",
2193 fdp_idx, n);
2194 /* Proceed without registering FDP streams */
2195 ret = 0;
2196 goto out;
2197 }
2198
2199 log = h + 1;
2200 desc = log;
2201 for (i = 0; i < fdp_idx; i++) {
2202 log += le16_to_cpu(desc->dsze);
2203 desc = log;
2204 }
2205
2206 if (le32_to_cpu(desc->nrg) > 1) {
2207 dev_warn(ctrl->device, "FDP NRG > 1 not supported\n");
2208 ret = 0;
2209 goto out;
2210 }
2211
2212 info->runs = le64_to_cpu(desc->runs);
2213 out:
2214 kfree(h);
2215 return ret;
2216 }
2217

--
0-DAY CI Kernel Test Service