Linux-NVME Archive on lore.kernel.org
 help / color / mirror / Atom feed
From: Christoph Hellwig <hch@lst.de>
To: Luis Chamberlain <mcgrof@kernel.org>
Cc: hch@lst.de, sagi@grimberg.me, kch@nvidia.com,
	linux-nvme@lists.infradead.org, gost.dev@samsung.com,
	John Garry <john.g.garry@oracle.com>
Subject: Re: [PATCH] nvmet: propagate npwg and awupf topology
Date: Thu, 12 Dec 2024 06:52:50 +0100	[thread overview]
Message-ID: <20241212055250.GA4825@lst.de> (raw)
In-Reply-To: <20241212033148.4008110-1-mcgrof@kernel.org>

On Wed, Dec 11, 2024 at 07:31:47PM -0800, Luis Chamberlain wrote:
> Ensure we propagate npwg and awupf to the target as well instead
> of assuming its the same logical blocks per physical block.
> 
> This ensures devices with large IUs and large atomics get their
> information properly propagated on the target.

nvmet never sets REQ_ATOMIC and thus won't get atomic writes from
say SCSI.  So supporting atomic writes is a little more work than
just propagating the values.



  reply	other threads:[~2024-12-12  5:53 UTC|newest]

Thread overview: 4+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2024-12-12  3:31 [PATCH] nvmet: propagate npwg and awupf topology Luis Chamberlain
2024-12-12  5:52 ` Christoph Hellwig [this message]
2024-12-12 11:25   ` John Garry
2024-12-13 23:13     ` Luis Chamberlain

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20241212055250.GA4825@lst.de \
    --to=hch@lst.de \
    --cc=gost.dev@samsung.com \
    --cc=john.g.garry@oracle.com \
    --cc=kch@nvidia.com \
    --cc=linux-nvme@lists.infradead.org \
    --cc=mcgrof@kernel.org \
    --cc=sagi@grimberg.me \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox