Re: [PATCH v4 2/9] sched/isolation: document HK_TYPE housekeeping option

Waiman Long
2025-01-07T16:02:50Z

On 12/17/24 1:29 PM, Daniel Wagner wrote:
> The enum is a public API which can be used all over the kernel. This
> warrants a bit of documentation.
>
> Signed-off-by: Daniel Wagner <wagi@kernel.org>
> ---
> include/linux/sched/isolation.h | 13 +++++++++++++
> 1 file changed, 13 insertions(+)
>
> diff --git a/include/linux/sched/isolation.h b/include/linux/sched/isolation.h
> index 2b461129d1fad0fd0ef1ad759fe44695dc635e8c..6649c3a48e0ea0a88c84bf5f2a74bff039fadaf2 100644
> --- a/include/linux/sched/isolation.h
> +++ b/include/linux/sched/isolation.h
> @@ -6,6 +6,19 @@
> #include <linux/init.h>
> #include <linux/tick.h>
>
> +/**
> + * enum hk_type - housekeeping cpu mask types
> + * @HK_TYPE_TIMER: housekeeping cpu mask for timers
> + * @HK_TYPE_RCU: housekeeping cpu mask for RCU
> + * @HK_TYPE_MISC: housekeeping cpu mask for miscalleanous resources
> + * @HK_TYPE_SCHED: housekeeping cpu mask for scheduling
> + * @HK_TYPE_TICK: housekeeping cpu maks for timer tick
> + * @HK_TYPE_DOMAIN: housekeeping cpu mask for general SMP balancing
> + * and scheduling algoririthms
> + * @HK_TYPE_WQ: housekeeping cpu mask for worksqueues
> + * @HK_TYPE_MANAGED_IRQ: housekeeping cpu mask for managed IRQs
> + * @HK_TYPE_KTHREAD: housekeeping cpu mask for kthreads
> + */
> enum hk_type {
> HK_TYPE_TIMER,
> HK_TYPE_RCU,
>
The various housekeeping types are in the process of being consolidated
as most of them cannot be set independently. See commit 6010d245ddc9
("sched/isolation: Consolidate housekeeping cpumasks that are always
identical") in linux-next or tip. So this patch will have conflict.

Cheers,
Longman