From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 5FDAEE77188 for ; Mon, 6 Jan 2025 10:58:44 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender:List-Subscribe:List-Help :List-Post:List-Archive:List-Unsubscribe:List-Id:In-Reply-To:Content-Type: MIME-Version:References:Message-ID:Subject:Cc:To:From:Date:Reply-To: Content-Transfer-Encoding:Content-ID:Content-Description:Resent-Date: Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID:List-Owner; bh=hKV+7G2lsPSXWjYYeFvLeXfYpDcDcbPcSxXFXE7hzXI=; b=ZSoCl9v/s46kfz21nTzKtvx123 N5dVneOxmOtb3lbpstdSTTXAKyXEEK6H/UGtoFzMlPM4rHhR6F/97N1G90CqzScVpSyd9CsuP1bRr pLLSSpT13LH0du3q82V+4fQWShBM3liEX45uVsdopkxO8m3FEZmTOZMUTbAhVTFgD+mo6qaYS8f6d SObwpip6gvblc4exSrv3cHiOMfrU9POl9B8VmzTDV7XujII83dRxao5BfzCeQwKXfIHviwG2MAQYC RyDfCxYp9jRUABS5vSGbyypkelWY3VoQu7Ayat6RVId3u3cCdQZGn890LW2tSXzNlxkBncvGYsDQN yTnuptgw==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.98 #2 (Red Hat Linux)) id 1tUkok-00000000wry-2D8j; Mon, 06 Jan 2025 10:58:42 +0000 Received: from verein.lst.de ([213.95.11.211]) by bombadil.infradead.org with esmtps (Exim 4.98 #2 (Red Hat Linux)) id 1tUknh-00000000wTT-3UtH for linux-nvme@lists.infradead.org; Mon, 06 Jan 2025 10:57:39 +0000 Received: by verein.lst.de (Postfix, from userid 2407) id 7D08D68C7B; Mon, 6 Jan 2025 11:57:32 +0100 (CET) Date: Mon, 6 Jan 2025 11:57:32 +0100 From: Christoph Hellwig To: Damien Le Moal Cc: Christoph Hellwig , Jens Axboe , Ming Lei , Nilay Shroff , linux-block@vger.kernel.org, linux-nvme@lists.infradead.org, nbd@other.debian.org, virtualization@lists.linux.dev, linux-scsi@vger.kernel.org, usb-storage@lists.one-eyed-alien.net Subject: Re: [PATCH 03/10] block: add a store_limit operations for sysfs entries Message-ID: <20250106105732.GA21833@lst.de> References: <20250106100645.850445-1-hch@lst.de> <20250106100645.850445-4-hch@lst.de> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: User-Agent: Mutt/1.5.17 (2007-11-01) X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20250106_025738_012645_57E54AB0 X-CRM114-Status: GOOD ( 11.91 ) X-BeenThere: linux-nvme@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: "Linux-nvme" Errors-To: linux-nvme-bounces+linux-nvme=archiver.kernel.org@lists.infradead.org On Mon, Jan 06, 2025 at 07:46:19PM +0900, Damien Le Moal wrote: > The freeze must NOT be done for the "if (entry->store_limit)" case. So this > needs to go int the "else". Otherwise, you still have freeze the take limit > lock order which can cause the ABBA deadlocks in SCSI sd. That is fixed in the next patch. This one is pure refactoring without behavior change.