From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id D4C71C02181 for ; Wed, 22 Jan 2025 06:33:13 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender:List-Subscribe:List-Help :List-Post:List-Archive:List-Unsubscribe:List-Id:In-Reply-To:Content-Type: MIME-Version:References:Message-ID:Subject:Cc:To:From:Date:Reply-To: Content-Transfer-Encoding:Content-ID:Content-Description:Resent-Date: Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID:List-Owner; bh=GYJzEwIQBHEGL7aDYcJ5bTXyzU9977MRchbIzgX7Uuk=; b=iFr9s2WvF2QikCE+jyKmVdGiZK lGv+2qXxmmlbqWsNrbNUKw1jBsSZYXQf4HSQMAsYDwtCy3DagM6/2DBsYPokfytOgKNhiphfOj1Br xz/XB6YFiRChfCOQebZrHVSBduVwb7JrH5LFzoHH98JnBy/Pkqd+6+nNHgamEx74CZ9rigBnFRVQk 3ujAh0CfDCoHNpf9o2B4fxTEvKpRgn7HIzhQ/dPlBowA3q8IkRuxkbWZqTOKHOAv/pLOrv2DZenn4 k0p98TdlXLxS/dbdv6jM1Rm7jxXNJm4h+00NP15qx4XikUhd4e8IGfq8MXVpZOr/vxFWDcSitH718 OZNJbjMA==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.98 #2 (Red Hat Linux)) id 1taUIV-00000009VCv-2yWP; Wed, 22 Jan 2025 06:33:07 +0000 Received: from verein.lst.de ([213.95.11.211]) by bombadil.infradead.org with esmtps (Exim 4.98 #2 (Red Hat Linux)) id 1taUIS-00000009V9s-0VD1; Wed, 22 Jan 2025 06:33:05 +0000 Received: by verein.lst.de (Postfix, from userid 2407) id 5197C68D05; Wed, 22 Jan 2025 07:32:51 +0100 (CET) Date: Wed, 22 Jan 2025 07:32:51 +0100 From: Christoph Hellwig To: Ming Lei Cc: Christoph Hellwig , Jens Axboe , linux-block@vger.kernel.org, nbd@other.debian.org, ceph-devel@vger.kernel.org, virtualization@lists.linux.dev, linux-mtd@lists.infradead.org, linux-nvme@lists.infradead.org, linux-scsi@vger.kernel.org Subject: Re: [PATCH 1/2] loop: force GFP_NOIO for underlying file systems allocations Message-ID: <20250122063251.GA31207@lst.de> References: <20250117074442.256705-1-hch@lst.de> <20250117074442.256705-2-hch@lst.de> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: User-Agent: Mutt/1.5.17 (2007-11-01) X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20250121_223304_293450_D6A48F55 X-CRM114-Status: GOOD ( 11.20 ) X-BeenThere: linux-nvme@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: "Linux-nvme" Errors-To: linux-nvme-bounces+linux-nvme=archiver.kernel.org@lists.infradead.org On Fri, Jan 17, 2025 at 07:56:48PM +0800, Ming Lei wrote: > If we call memalloc_noio_save() here, setting PF_MEMALLOC_NOIO can be removed > from loop_process_work(). Nah, we can skip this patch as the explicit PF_MEMALLOC_NOIO does everything that is needed.