From: Christoph Hellwig <hch@lst.de>
To: Keith Busch <kbusch@meta.com>
Cc: linux-nvme@lists.infradead.org, hch@lst.de, sagi@grimberg.me,
nilay@linux.ibm.com, Keith Busch <kbusch@kernel.org>
Subject: Re: [PATCHv2] nvme-pci: fix stuck reset on concurrent DPC and HP
Date: Mon, 10 Mar 2025 14:23:11 +0100 [thread overview]
Message-ID: <20250310132311.GA8835@lst.de> (raw)
In-Reply-To: <20250307232618.2141065-1-kbusch@meta.com>
On Fri, Mar 07, 2025 at 03:26:18PM -0800, Keith Busch wrote:
> struct request *abort_req;
> struct nvme_command cmd = { };
> + struct pci_dev *pdev = to_pci_dev(dev->dev);
> u32 csts = readl(dev->bar + NVME_REG_CSTS);
> u8 opcode;
>
> + if (pci_dev_is_disconnected(pdev))
> + nvme_change_ctrl_state(&dev->ctrl, NVME_CTRL_DELETING);
Can you add a comment here (based on the commit message) explaining the
logic here, as it is anything but obvious?
Otherwise this looks good to me.
prev parent reply other threads:[~2025-03-10 14:49 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2025-03-07 23:26 [PATCHv2] nvme-pci: fix stuck reset on concurrent DPC and HP Keith Busch
2025-03-08 7:51 ` Nilay Shroff
2025-03-10 13:23 ` Christoph Hellwig [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20250310132311.GA8835@lst.de \
--to=hch@lst.de \
--cc=kbusch@kernel.org \
--cc=kbusch@meta.com \
--cc=linux-nvme@lists.infradead.org \
--cc=nilay@linux.ibm.com \
--cc=sagi@grimberg.me \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox