From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 0F819C28B2E for ; Tue, 11 Mar 2025 06:40:37 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender:List-Subscribe:List-Help :List-Post:List-Archive:List-Unsubscribe:List-Id:Content-Transfer-Encoding: Content-Type:Mime-Version:References:In-Reply-To:Message-Id:Subject:Cc:To: From:Date:Reply-To:Content-ID:Content-Description:Resent-Date:Resent-From: Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID:List-Owner; bh=DpzCarWmeMfBwSWeZiWSfmCFOtEoyAGB9/rlV34qIyY=; b=ZgGV7iZahh2x4ZfcOLCzd1deeZ 3enUmRFGvzlMCXQn9YzE3vFxjMki8vCTJKOH3r5Qo4KlUM1tBNVSIJZCYTpigHEDsPnEQsp+L31/Q RRdmte1rF00wxC3bx4xLnNw4Ad4EdGfFDb9uul62qgWajyWLT6JZJbgFc3o9i9H9qyXPZt7r2Bpij qePv0y9US4PG2dT4MsW5i6RJFqWiynX7QX0vxmKx9WbUYJgp3udXha25rD7lin15RmZc5++fWsZbW gnDIGcfStnVbDwMlPUfFbN5FrFfcR4j/IHtf+qa5AYc7RNUHhsYCFqOVwxR1oattlTL8xMZKBlPwC ynLCXaUg==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.98 #2 (Red Hat Linux)) id 1trtHz-00000004ldr-3T2k; Tue, 11 Mar 2025 06:40:31 +0000 Received: from nyc.source.kernel.org ([2604:1380:45d1:ec00::3]) by bombadil.infradead.org with esmtps (Exim 4.98 #2 (Red Hat Linux)) id 1trp2N-00000004Ob6-3ivW; Tue, 11 Mar 2025 02:08:09 +0000 Received: from smtp.kernel.org (transwarp.subspace.kernel.org [100.75.92.58]) by nyc.source.kernel.org (Postfix) with ESMTP id 8CA06A4656C; Tue, 11 Mar 2025 02:02:36 +0000 (UTC) Received: by smtp.kernel.org (Postfix) with ESMTPSA id 872A9C4CEE5; Tue, 11 Mar 2025 02:08:04 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=linux-foundation.org; s=korg; t=1741658886; bh=EO2y2EASnimfmC0To8IgjADGLB03IrpBXSrBRgvMOXc=; h=Date:From:To:Cc:Subject:In-Reply-To:References:From; b=wQfQZG6IKVV4Tew+S+0o+lnw12y0URQfWSPems1i8x5dKQTaPMYHdQMJDIg/0LCcq 9ysqdCzIccJgUTy5+1XImjyPHewrVrCASW3U/ThAkRtkSNX1mJCMOLQBPQJNwR3UZE sXCoysWhDTs3Eikr7+eLtWHhOyIiad0yrUckBntM= Date: Mon, 10 Mar 2025 19:08:03 -0700 From: Andrew Morton To: "Martin K. Petersen" Cc: Yaron Avizrat , Oded Gabbay , Julia Lawall , Nicolas Palix , James Smart , Dick Kennedy , "James E.J. Bottomley" , Jaroslav Kysela , Takashi Iwai , Chris Mason , Josef Bacik , David Sterba , Ilya Dryomov , Dongsheng Yang , Jens Axboe , Xiubo Li , Damien Le Moal , Niklas Cassel , Carlos Maiolino , "Darrick J. Wong" , Sebastian Reichel , Keith Busch , Christoph Hellwig , Sagi Grimberg , Frank Li , Mark Brown , Shawn Guo , Sascha Hauer , Pengutronix Kernel Team , Fabio Estevam , Shyam Sundar S K , Hans de Goede , Ilpo =?ISO-8859-1?Q?J=E4rvinen?= , Henrique de Moraes Holschuh , Selvin Xavier , Kalesh AP , Jason Gunthorpe , Leon Romanovsky , Easwar Hariharan , cocci@inria.fr, linux-kernel@vger.kernel.org, linux-scsi@vger.kernel.org, dri-devel@lists.freedesktop.org, linux-sound@vger.kernel.org, linux-btrfs@vger.kernel.org, ceph-devel@vger.kernel.org, linux-block@vger.kernel.org, linux-ide@vger.kernel.org, linux-xfs@vger.kernel.org, linux-pm@vger.kernel.org, linux-nvme@lists.infradead.org, linux-spi@vger.kernel.org, imx@lists.linux.dev, linux-arm-kernel@lists.infradead.org, platform-driver-x86@vger.kernel.org, ibm-acpi-devel@lists.sourceforge.net, linux-rdma@vger.kernel.org, Takashi Iwai , Carlos Maiolino Subject: Re: (subset) [PATCH v3 00/16] Converge on using secs_to_jiffies() part two Message-Id: <20250310190803.aaf868760781c9ae3fbe6df1@linux-foundation.org> In-Reply-To: <174165504986.528513.3575505677065987375.b4-ty@oracle.com> References: <20250225-converge-secs-to-jiffies-part-two-v3-0-a43967e36c88@linux.microsoft.com> <174165504986.528513.3575505677065987375.b4-ty@oracle.com> X-Mailer: Sylpheed 3.8.0beta1 (GTK+ 2.24.33; x86_64-pc-linux-gnu) Mime-Version: 1.0 Content-Type: text/plain; charset=US-ASCII Content-Transfer-Encoding: 7bit X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20250310_190808_058516_FF5CBBFA X-CRM114-Status: GOOD ( 18.70 ) X-Mailman-Approved-At: Mon, 10 Mar 2025 23:40:29 -0700 X-BeenThere: linux-nvme@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: "Linux-nvme" Errors-To: linux-nvme-bounces+linux-nvme=archiver.kernel.org@lists.infradead.org On Mon, 10 Mar 2025 21:19:03 -0400 "Martin K. Petersen" wrote: > On Tue, 25 Feb 2025 20:17:14 +0000, Easwar Hariharan wrote: > > > This is the second series (part 1*) that converts users of msecs_to_jiffies() that > > either use the multiply pattern of either of: > > - msecs_to_jiffies(N*1000) or > > - msecs_to_jiffies(N*MSEC_PER_SEC) > > > > where N is a constant or an expression, to avoid the multiplication. > > > > [...] > > Applied to 6.15/scsi-queue, thanks! > > [02/16] scsi: lpfc: convert timeouts to secs_to_jiffies() > https://git.kernel.org/mkp/scsi/c/a131f20804d6 Really, an acked-by would have been much easier all around, but whatever. Did you get my fix? From: Andrew Morton Subject: scsi-lpfc-convert-timeouts-to-secs_to_jiffies-fix Date: Tue Feb 25 07:32:03 PM PST 2025 fix build Cc: Easwar Hariharan Cc: James Bottomley Signed-off-by: Andrew Morton --- drivers/scsi/lpfc/lpfc_sli.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) --- a/drivers/scsi/lpfc/lpfc_sli.c~scsi-lpfc-convert-timeouts-to-secs_to_jiffies-fix +++ a/drivers/scsi/lpfc/lpfc_sli.c @@ -3954,7 +3954,7 @@ void lpfc_poll_eratt(struct timer_list * else /* Restart the timer for next eratt poll */ mod_timer(&phba->eratt_poll, - jiffies + secs_to_jiffies(phba->eratt_poll_interval); + jiffies + secs_to_jiffies(phba->eratt_poll_interval)); return; } _